klmp200/Sith
1
0
Fork 0
mirror of https://github.com/ae-utbm/sith.git synced 2024-12-31 12:11:16 +00:00
Code Issues Packages Projects Releases Wiki Activity

counter: fix error for stats 500 on PermissionDenied

Browse Source
This commit is contained in:
Antoine Bartuccio 2019-05-28 16:38:18 +02:00
parent d466d645e6
commit f0524a9f00
2 changed files with 13 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
counter/tests.py
View File

@ -83,6 +83,17 @@ class CounterTest(TestCase):
)
class CounterStatsTest(TestCase):
def setUp(self):
call_command("populate")
self.counter = Counter.objects.filter(id=2).first()
def test_unothorized_user_fail(self):
# Test with not login user
response = self.client.get(reverse("counter:stats", args=[self.counter.id]))
self.assertTrue(response.status_code == 403)
class BarmanConnectionTest(TestCase):
def setUp(self):
call_command("populate")

4
counter/views.py
View File

@ -1522,11 +1522,11 @@ class CounterStatView(DetailView, CounterAdminMixin):
def dispatch(self, request, *args, **kwargs):
try:
return super(CounterStatView, self).dispatch(request, *args, **kwargs)
except:
except PermissionDenied:
if (
request.user.is_root
or request.user.is_board_member
or self.object.is_owned_by(request.user)
or self.get_object().is_owned_by(request.user)
):
return super(CanEditMixin, self).dispatch(request, *args, **kwargs)
raise PermissionDenied