rename User.is_subscriber_viewable => User.is_viewable

sas/models.py

@@ -270,9 +270,7 @@ class PeoplePictureRelationQuerySet(models.QuerySet):
         if user.is_root or user.is_in_group(pk=settings.SITH_GROUP_SAS_ADMIN_ID):
             return self
         if user.was_subscribed:
-            return self.filter(
-                Q(user_id=user.id) | Q(user__is_subscriber_viewable=True)
-            )
+            return self.filter(Q(user_id=user.id) | Q(user__is_viewable=True))
         return self.filter(user_id=user.id)
 
 

sas/tests/test_api.py

@@ -189,7 +189,7 @@ class TestPictureRelation(TestSas):
     def test_fetch_relations_including_hidden_users(self):
         """Test that normal subscribers users cannot see hidden profiles"""
         picture = self.album_a.children_pictures.last()
-        self.user_a.is_subscriber_viewable = False
+        self.user_a.is_viewable = False
         self.user_a.save()
         url = reverse("api:picture_identifications", kwargs={"picture_id": picture.id})
 

sas/tests/test_model.py

@@ -53,7 +53,7 @@ def test_identifications_viewable_by_user():
     identifications = baker.make(
         PeoplePictureRelation, picture=picture, _quantity=10, _bulk_create=True
     )
-    identifications[0].user.is_subscriber_viewable = False
+    identifications[0].user.is_viewable = False
     identifications[0].user.save()
 
     assert (