apply review comments

This commit is contained in:
imperosol
2026-05-16 23:21:48 +02:00
parent 0ce03b4f5c
commit 5b25a08473
4 changed files with 12 additions and 5 deletions
+1 -1
View File
@@ -44,7 +44,7 @@
<ul> <ul>
{% for link in links %} {% for link in links %}
<li> <li>
<a href="{{ link.url }}" rel="noopener" target="_blank"> <a href="{{ link.url }}" rel="noopener external" target="_blank">
<i class="{{ link.link_type.icon }} fa-xl"></i>{{ link.name }} <i class="{{ link.link_type.icon }} fa-xl"></i>{{ link.name }}
</a> </a>
</li> </li>
+1 -1
View File
@@ -67,7 +67,7 @@
<br> <br>
<div class="row gap-2x"> <div class="row gap-2x">
{% for link in club.links.all() %} {% for link in club.links.all() %}
<a href="{{ link.url }}"> <a href="{{ link.url }}" rel="noopener external" target="_blank">
<i class="{{ link.link_type.icon }} fa-xl"></i> <i class="{{ link.link_type.icon }} fa-xl"></i>
<strong>{{ link.name }}</strong> <strong>{{ link.name }}</strong>
</a> </a>
+4 -1
View File
@@ -27,7 +27,10 @@
{# we change the icon when the user change it and leave the input, {# we change the icon when the user change it and leave the input,
or when it is pasted from the clipboard #} or when it is pasted from the clipboard #}
{{ form.url|add_attr("x-model.change=url,@paste.prevent=url = $event.clipboardData.getData('text')") }} {{ form.url|add_attr("x-model.change=url,@paste.prevent=url = $event.clipboardData.getData('text')") }}
<i :class="linkType.icon || 'fa fa-link'"></i> <i
:class="linkType.icon || 'fa fa-link'"
tooltip="{% trans %}This icon will change according to the given url.{% endtrans %}"
></i>
</span> </span>
</div> </div>
<div>{{ form.name.as_field_group() }}</div> <div>{{ form.name.as_field_group() }}</div>
+6 -2
View File
@@ -643,6 +643,10 @@ msgstr "Comptoirs : "
msgid "Edit %(name)s" msgid "Edit %(name)s"
msgstr "Éditer %(name)s" msgstr "Éditer %(name)s"
#: club/templates/club/edit_club.jinja
msgid "This icon will change according to the given url."
msgstr "Cette icône changera en fonction de l'url fournie"
#: club/templates/club/edit_club.jinja #: club/templates/club/edit_club.jinja
msgid "Remove link" msgid "Remove link"
msgstr "Retirer le lien" msgstr "Retirer le lien"
@@ -680,8 +684,8 @@ msgid ""
"Note: if the icon of one of your links doesn't exist yet, you can ask the " "Note: if the icon of one of your links doesn't exist yet, you can ask the "
"info team to add it." "info team to add it."
msgstr "" msgstr ""
"Note : si l'icône d'un de vos liens n'existe pas encore, vous pouvez demander " "Note : si l'icône d'un de vos liens n'existe pas encore, vous pouvez "
"au pôle info de l'ajouter." "demander au pôle info de l'ajouter."
#: club/templates/club/edit_club.jinja #: club/templates/club/edit_club.jinja
msgid "Add link" msgid "Add link"