From 5b25a084736119496063a7baa137b2e5c93aac4d Mon Sep 17 00:00:00 2001
From: imperosol <thgirod@hotmail.com>
Date: Sat, 16 May 2026 23:21:48 +0200
Subject: [PATCH] apply review comments

---
 club/templates/club/club_detail.jinja | 2 +-
 club/templates/club/club_list.jinja   | 2 +-
 club/templates/club/edit_club.jinja   | 5 ++++-
 locale/fr/LC_MESSAGES/django.po       | 8 ++++++--
 4 files changed, 12 insertions(+), 5 deletions(-)

diff --git a/club/templates/club/club_detail.jinja b/club/templates/club/club_detail.jinja
index c1e1f583..bc1a1c0b 100644
--- a/club/templates/club/club_detail.jinja
+++ b/club/templates/club/club_detail.jinja
@@ -44,7 +44,7 @@
           <ul>
             {% for link in links %}
               <li>
-                <a href="{{ link.url }}" rel="noopener" target="_blank">
+                <a href="{{ link.url }}" rel="noopener external" target="_blank">
                   <i class="{{ link.link_type.icon }} fa-xl"></i>{{ link.name }}
                 </a>
               </li>
diff --git a/club/templates/club/club_list.jinja b/club/templates/club/club_list.jinja
index 2018785e..75f174fd 100644
--- a/club/templates/club/club_list.jinja
+++ b/club/templates/club/club_list.jinja
@@ -67,7 +67,7 @@
               <br>
               <div class="row gap-2x">
                 {% for link in club.links.all() %}
-                  <a href="{{ link.url }}">
+                  <a href="{{ link.url }}" rel="noopener external" target="_blank">
                     <i class="{{ link.link_type.icon }} fa-xl"></i>
                     <strong>{{ link.name }}</strong>
                   </a>
diff --git a/club/templates/club/edit_club.jinja b/club/templates/club/edit_club.jinja
index d1d6aa2c..a8f4093e 100644
--- a/club/templates/club/edit_club.jinja
+++ b/club/templates/club/edit_club.jinja
@@ -27,7 +27,10 @@
           {# we change the icon when the user change it and leave the input,
              or when it is pasted from the clipboard #}
           {{ form.url|add_attr("x-model.change=url,@paste.prevent=url = $event.clipboardData.getData('text')") }}
-          <i :class="linkType.icon || 'fa fa-link'"></i>
+          <i
+            :class="linkType.icon || 'fa fa-link'"
+            tooltip="{% trans %}This icon will change according to the given url.{% endtrans %}"
+          ></i>
         </span>
       </div>
       <div>{{ form.name.as_field_group() }}</div>
diff --git a/locale/fr/LC_MESSAGES/django.po b/locale/fr/LC_MESSAGES/django.po
index a393b87e..b51392ca 100644
--- a/locale/fr/LC_MESSAGES/django.po
+++ b/locale/fr/LC_MESSAGES/django.po
@@ -643,6 +643,10 @@ msgstr "Comptoirs : "
 msgid "Edit %(name)s"
 msgstr "Éditer %(name)s"
 
+#: club/templates/club/edit_club.jinja
+msgid "This icon will change according to the given url."
+msgstr "Cette icône changera en fonction de l'url fournie"
+
 #: club/templates/club/edit_club.jinja
 msgid "Remove link"
 msgstr "Retirer le lien"
@@ -680,8 +684,8 @@ msgid ""
 "Note: if the icon of one of your links doesn't exist yet, you can ask the "
 "info team to add it."
 msgstr ""
-"Note : si l'icône d'un de vos liens n'existe pas encore, vous pouvez demander "
-"au pôle info de l'ajouter."
+"Note : si l'icône d'un de vos liens n'existe pas encore, vous pouvez "
+"demander au pôle info de l'ajouter."
 
 #: club/templates/club/edit_club.jinja
 msgid "Add link"