klmp200/Sith
1
0
Fork 0
mirror of https://github.com/ae-utbm/sith.git synced 2024-11-22 14:13:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

sas: fix 500 error when tagging the same user twice or adding a non existing user

Browse Source
This commit is contained in:
Antoine Bartuccio 2019-12-17 10:51:19 +01:00
parent ebee8c34e1
commit 4a1bfc366d
Signed by: klmp200
GPG Key ID: E7245548C53F904B
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
sas/views.py
View File

@ -180,6 +180,12 @@ class PictureView(CanViewMixin, DetailView, FormMixin):
if self.form.is_valid(): if self.form.is_valid():
for uid in self.form.cleaned_data["users"]: for uid in self.form.cleaned_data["users"]:
u = User.objects.filter(id=uid).first() u = User.objects.filter(id=uid).first()
if not u: # Don't use a non existing user
continue
if PeoplePictureRelation.objects.filter(
user=u, picture=self.form.cleaned_data["picture"]
).exists(): # Avoid existing relation
continue
PeoplePictureRelation( PeoplePictureRelation(
user=u, picture=self.form.cleaned_data["picture"] user=u, picture=self.form.cleaned_data["picture"]
).save() ).save()