From 4a1bfc366daea85cdff455d78c46e26f2dcafeef Mon Sep 17 00:00:00 2001 From: Bartuccio Antoine Date: Tue, 17 Dec 2019 10:51:19 +0100 Subject: [PATCH] sas: fix 500 error when tagging the same user twice or adding a non existing user --- sas/views.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/sas/views.py b/sas/views.py index 941e2bb6..a43369e4 100644 --- a/sas/views.py +++ b/sas/views.py @@ -180,6 +180,12 @@ class PictureView(CanViewMixin, DetailView, FormMixin): if self.form.is_valid(): for uid in self.form.cleaned_data["users"]: u = User.objects.filter(id=uid).first() + if not u: # Don't use a non existing user + continue + if PeoplePictureRelation.objects.filter( + user=u, picture=self.form.cleaned_data["picture"] + ).exists(): # Avoid existing relation + continue PeoplePictureRelation( user=u, picture=self.form.cleaned_data["picture"] ).save()