klmp200/Sith
1
0
Fork 0
mirror of https://github.com/ae-utbm/sith.git synced 2024-11-21 21:53:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Apply review comments

Browse Source
This commit is contained in:
Antoine Bartuccio 2024-10-10 15:42:11 +02:00
parent 849177562d
commit 32444fac90
9 changed files with 28 additions and 29 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
core/static/webpack/user/family-graph-index.js
View File

@ -170,9 +170,9 @@ function createGraph(container, data, activeUserId) {
/** /**
* @typedef FamilyGraphConfig * @typedef FamilyGraphConfig
* @param {number} activeUser Id of the user to fetch the tree from * @property {number} activeUser Id of the user to fetch the tree from
* @param {number} depthMin Minimum tree depth for godfathers and godchildren * @property {number} depthMin Minimum tree depth for godfathers and godchildren
* @param {number} depthMax Maximum tree depth for godfathers and godchildren * @property {number} depthMax Maximum tree depth for godfathers and godchildren
**/ **/
/** /**

2
core/static/webpack/user/pictures-index.js
View File

@ -30,7 +30,7 @@ import { picturesFetchPictures } from "#openapi";
/** /**
* @typedef PicturePageConfig * @typedef PicturePageConfig
* @param {number} userId Id of the user to get the pictures from * @property {number} userId Id of the user to get the pictures from
**/ **/
/** /**

4
docs/howto/statics.md
View File

@ -48,9 +48,9 @@ Pour accéder au fichier, il faut utiliser `static` comme pour le reste mais en
### Les imports au sein des fichiers de webpack ### Les imports au sein des fichiers de webpack
Pour importer au sein de webpack, faut préfixer ses imports de `#app:`. Pour importer au sein de webpack, il faut préfixer ses imports de `#app:`.
Example: Exemple:
```js ```js
import { paginated } from "#core:utils/api"; import { paginated } from "#core:utils/api";

6
openapi-ts.config.ts
View File

@ -1,10 +1,10 @@
// biome-ignore lint/correctness/noNodejsModules: this only used at compile time // biome-ignore lint/correctness/noNodejsModules: this only used at compile time
const path = require("node:path"); import { resolve } from "node:path";
import { defineConfig } from "@hey-api/openapi-ts"; import { defineConfig } from "@hey-api/openapi-ts";
// biome-ignore lint/style/noDefaultExport: needed for openapi-ts // biome-ignore lint/style/noDefaultExport: needed for openapi-ts
export default defineConfig({ export default defineConfig({
client: "@hey-api/client-fetch", client: "@hey-api/client-fetch",
input: path.resolve(__dirname, "./staticfiles/generated/openapi/schema.json"), input: resolve(__dirname, "./staticfiles/generated/openapi/schema.json"),
output: path.resolve(__dirname, "./staticfiles/generated/openapi"), output: resolve(__dirname, "./staticfiles/generated/openapi"),
}); });

8
sas/static/webpack/sas/viewer-index.js
View File

@ -81,10 +81,10 @@ class PictureWithIdentifications {
/** /**
* @typedef ViewerConfig * @typedef ViewerConfig
* @param {number} userId Id of the user to get the pictures from * @property {number} userId Id of the user to get the pictures from
* @param {number} albumId Id of the album to displlay * @property {number} albumId Id of the album to displlay
* @param {number} firstPictureId id of the first picture to load on the page * @property {number} firstPictureId id of the first picture to load on the page
* @param {bool} userIsSasAdmin if the user is sas admin * @property {bool} userIsSasAdmin if the user is sas admin
**/ **/
/** /**

2
staticfiles/storage.py
View File

@ -27,7 +27,7 @@ class ManifestPostProcessingStorage(ManifestStaticFilesStorage):
) )
name = str(path.with_suffix(".css")) name = str(path.with_suffix(".css"))
if path.suffix == ".ts": elif path.suffix == ".ts":
name = str(path.with_suffix(".js")) name = str(path.with_suffix(".js"))
return super().url(name, force=force) return super().url(name, force=force)

1
tsconfig.json
View File

@ -5,7 +5,6 @@
"noImplicitAny": true, "noImplicitAny": true,
"module": "es6", "module": "es6",
"target": "es5", "target": "es5",
"jsx": "react",
"allowJs": true, "allowJs": true,
"moduleResolution": "node", "moduleResolution": "node",
"paths": { "paths": {

2
webpack.config.js
View File

@ -23,7 +23,7 @@ module.exports = {
return obj; return obj;
}, {}), }, {}),
cache: { cache: {
type: "filesystem", // This reduces typescript compilation time like crazy type: "filesystem", // This reduces typescript compilation time like crazy when you restart the server
}, },
output: { output: {
filename: "[name].js", filename: "[name].js",