Apply review comments

This commit is contained in:
Antoine Bartuccio 2024-10-10 15:42:11 +02:00
parent 849177562d
commit 32444fac90
9 changed files with 28 additions and 29 deletions

View File

@ -170,9 +170,9 @@ function createGraph(container, data, activeUserId) {
/**
* @typedef FamilyGraphConfig
* @param {number} activeUser Id of the user to fetch the tree from
* @param {number} depthMin Minimum tree depth for godfathers and godchildren
* @param {number} depthMax Maximum tree depth for godfathers and godchildren
* @property {number} activeUser Id of the user to fetch the tree from
* @property {number} depthMin Minimum tree depth for godfathers and godchildren
* @property {number} depthMax Maximum tree depth for godfathers and godchildren
**/
/**

View File

@ -30,7 +30,7 @@ import { picturesFetchPictures } from "#openapi";
/**
* @typedef PicturePageConfig
* @param {number} userId Id of the user to get the pictures from
* @property {number} userId Id of the user to get the pictures from
**/
/**

View File

@ -8,12 +8,12 @@ D'abord, il faut ajouter dans node via `package.json`:
```json
{
// ...
"imports": {
// ...
"#mon_app:*": "./mon_app/static/webpack/*"
}
// ...
// ...
"imports": {
// ...
"#mon_app:*": "./mon_app/static/webpack/*"
}
// ...
}
```
@ -21,13 +21,13 @@ Ensuite, pour faire fonctionne l'auto-complétion, il faut configurer `tsconfig.
```json
{
"compilerOptions": {
// ...
"paths": {
// ...
"#mon_app:*": ["./mon_app/static/webpack/*"]
}
}
"compilerOptions": {
// ...
"paths": {
// ...
"#mon_app:*": ["./mon_app/static/webpack/*"]
}
}
}
```

View File

@ -48,9 +48,9 @@ Pour accéder au fichier, il faut utiliser `static` comme pour le reste mais en
### Les imports au sein des fichiers de webpack
Pour importer au sein de webpack, faut préfixer ses imports de `#app:`.
Pour importer au sein de webpack, il faut préfixer ses imports de `#app:`.
Example:
Exemple:
```js
import { paginated } from "#core:utils/api";

View File

@ -1,10 +1,10 @@
// biome-ignore lint/correctness/noNodejsModules: this only used at compile time
const path = require("node:path");
import { resolve } from "node:path";
import { defineConfig } from "@hey-api/openapi-ts";
// biome-ignore lint/style/noDefaultExport: needed for openapi-ts
export default defineConfig({
client: "@hey-api/client-fetch",
input: path.resolve(__dirname, "./staticfiles/generated/openapi/schema.json"),
output: path.resolve(__dirname, "./staticfiles/generated/openapi"),
input: resolve(__dirname, "./staticfiles/generated/openapi/schema.json"),
output: resolve(__dirname, "./staticfiles/generated/openapi"),
});

View File

@ -81,10 +81,10 @@ class PictureWithIdentifications {
/**
* @typedef ViewerConfig
* @param {number} userId Id of the user to get the pictures from
* @param {number} albumId Id of the album to displlay
* @param {number} firstPictureId id of the first picture to load on the page
* @param {bool} userIsSasAdmin if the user is sas admin
* @property {number} userId Id of the user to get the pictures from
* @property {number} albumId Id of the album to displlay
* @property {number} firstPictureId id of the first picture to load on the page
* @property {bool} userIsSasAdmin if the user is sas admin
**/
/**

View File

@ -27,7 +27,7 @@ class ManifestPostProcessingStorage(ManifestStaticFilesStorage):
)
name = str(path.with_suffix(".css"))
if path.suffix == ".ts":
elif path.suffix == ".ts":
name = str(path.with_suffix(".js"))
return super().url(name, force=force)

View File

@ -5,7 +5,6 @@
"noImplicitAny": true,
"module": "es6",
"target": "es5",
"jsx": "react",
"allowJs": true,
"moduleResolution": "node",
"paths": {

View File

@ -23,7 +23,7 @@ module.exports = {
return obj;
}, {}),
cache: {
type: "filesystem", // This reduces typescript compilation time like crazy
type: "filesystem", // This reduces typescript compilation time like crazy when you restart the server
},
output: {
filename: "[name].js",