Automatically resize album thumbnail

core/templates/core/base/notifications.jinja

@@ -1,13 +1,13 @@
 <div id="quick-notifications"
-     x-data='{
+     x-data="{
              messages: [
              {%- for message in messages -%}
                {%- if not message.extra_tags -%}
-                 { tag: {{ message.tags|string|tojson }}, text: {{ message|string|tojson }} },
+                 { tag: '{{ message.tags }}', text: '{{ message }}' },
                {%- endif -%}
              {%- endfor -%}
              ]
-             }'
+             }"
      @quick-notification-add="(e) => messages.push(e?.detail)"
      @quick-notification-delete="messages = []">
   <template x-for="(message, index) in messages">

locale/fr/LC_MESSAGES/django.po

@@ -6,7 +6,7 @@
 msgid ""
 msgstr ""
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2026-04-25 01:00+0200\n"
+"POT-Creation-Date: 2026-03-23 22:21+0100\n"
 "PO-Revision-Date: 2016-07-18\n"
 "Last-Translator: Maréchal <thomas.girod@utbm.fr\n"
 "Language-Team: AE info <ae.info@utbm.fr>\n"
@@ -181,22 +181,6 @@ msgstr "Vous devez être cotisant pour faire partie d'un club"
 msgid "You are already a member of this club"
 msgstr "Vous êtes déjà membre de ce club."
 
-#: club/forms.py
-msgid "Club status"
-msgstr "État du club"
-
-#: club/forms.py
-msgid "Active"
-msgstr "Actif"
-
-#: club/forms.py
-msgid "Inactive"
-msgstr "Inactif"
-
-#: club/forms.py
-msgid "All clubs"
-msgstr "Tous les clubs"
-
 #: club/models.py
 msgid "slug name"
 msgstr "nom slug"
@@ -317,22 +301,37 @@ msgstr "Cet email est déjà abonné à cette mailing"
 msgid "Unregistered user"
 msgstr "Utilisateur non enregistré"
 
-#: club/templates/club/club_list.jinja
-msgid "The list of all clubs existing at UTBM."
-msgstr "La liste de tous les clubs existants à l'UTBM"
-
 #: club/templates/club/club_list.jinja
 msgid "Club list"
 msgstr "Liste des clubs"
 
+#: club/templates/club/club_list.jinja
+msgid "The list of all clubs existing at UTBM."
+msgstr "La liste de tous les clubs existants à l'UTBM"
+
 #: club/templates/club/club_list.jinja
 msgid "Filters"
 msgstr "Filtres"
 
-#: club/templates/club/club_list.jinja core/templates/core/base/header.jinja
-#: forum/templates/forum/macros.jinja matmat/templates/matmat/search_form.jinja
-msgid "Search"
-msgstr "Recherche"
+#: club/templates/club/club_list.jinja
+msgid "Name"
+msgstr "Nom"
+
+#: club/templates/club/club_list.jinja
+msgid "Club state"
+msgstr "Etat du club"
+
+#: club/templates/club/club_list.jinja
+msgid "Active"
+msgstr "Actif"
+
+#: club/templates/club/club_list.jinja
+msgid "Inactive"
+msgstr "Inactif"
+
+#: club/templates/club/club_list.jinja
+msgid "All clubs"
+msgstr "Tous les clubs"
 
 #: club/templates/club/club_list.jinja core/templates/core/user_tools.jinja
 msgid "New club"
@@ -1864,6 +1863,11 @@ msgstr "Connexion"
 msgid "Register"
 msgstr "Inscription"
 
+#: core/templates/core/base/header.jinja forum/templates/forum/macros.jinja
+#: matmat/templates/matmat/search_form.jinja
+msgid "Search"
+msgstr "Recherche"
+
 #: core/templates/core/base/header.jinja
 msgid "Logout"
 msgstr "Déconnexion"
@@ -4208,47 +4212,6 @@ msgstr ""
 msgid "this page"
 msgstr "cette page"
 
-#: eboutic/templates/eboutic/eboutic_main.jinja
-msgid "Eurockéennes 2025 partnership"
-msgstr "Partenariat Eurockéennes 2025"
-
-#: eboutic/templates/eboutic/eboutic_main.jinja
-msgid ""
-"Our partner uses Weezevent to sell tickets. Weezevent may collect user info "
-"according to its own privacy policy. By clicking the accept button you "
-"consent to their terms of services."
-msgstr ""
-"Notre partenaire utilises Wezevent pour vendre ses billets. Weezevent peut "
-"collecter des informations utilisateur conformément à sa propre politique de "
-"confidentialité. En cliquant sur le bouton d'acceptation vous consentez à "
-"leurs termes de service."
-
-#: eboutic/templates/eboutic/eboutic_main.jinja
-msgid "Privacy policy"
-msgstr "Politique de confidentialité"
-
-#: eboutic/templates/eboutic/eboutic_main.jinja
-#: trombi/templates/trombi/comment_moderation.jinja
-msgid "Accept"
-msgstr "Accepter"
-
-#: eboutic/templates/eboutic/eboutic_main.jinja
-msgid ""
-"You must be subscribed to benefit from the partnership with the Eurockéennes."
-msgstr ""
-"Vous devez être cotisant pour bénéficier du partenariat avec les "
-"Eurockéennes."
-
-#: eboutic/templates/eboutic/eboutic_main.jinja
-#, python-format
-msgid ""
-"This partnership offers a discount of up to 33%% on tickets for Friday, "
-"Saturday and Sunday, as well as the 3-day package from Friday to Sunday."
-msgstr ""
-"Ce partenariat permet de profiter d'une réduction jusqu'à 33%% sur les "
-"billets du vendredi, du samedi et du dimanche, ainsi qu'au forfait 3 jours, "
-"du vendredi au dimanche."
-
 #: eboutic/templates/eboutic/eboutic_main.jinja
 msgid "There are no items available for sale"
 msgstr "Aucun article n'est disponible à la vente"
@@ -5022,14 +4985,6 @@ msgstr "Envoyer les images"
 msgid "You already requested moderation for this picture."
 msgstr "Vous avez déjà déposé une demande de retrait pour cette photo."
 
-#: sas/forms.py
-msgid "Left"
-msgstr ""
-
-#: sas/forms.py
-msgid "Right"
-msgstr "Droite"
-
 #: sas/models.py
 msgid "picture"
 msgstr "photo"
@@ -5151,14 +5106,6 @@ msgstr "Photos de %(user_name)s"
 msgid "Download all my pictures"
 msgstr "Télécharger toutes mes photos"
 
-#: sas/views.py
-msgid ""
-"Newly rotated image might not be immediately displayed due to your web "
-"browser's cache"
-msgstr ""
-"Les images nouvellements pivotées peuvent ne pas s'afficher immédiatement "
-"à cause du cache de votre navigateur internet"
-
 #: sith/settings.py
 msgid "English"
 msgstr "Anglais"
@@ -5691,6 +5638,10 @@ msgstr "fin"
 msgid "Moderate Trombi comments"
 msgstr "Modérer les commentaires du Trombi"
 
+#: trombi/templates/trombi/comment_moderation.jinja
+msgid "Accept"
+msgstr "Accepter"
+
 #: trombi/templates/trombi/comment_moderation.jinja
 msgid "Reject"
 msgstr "Refuser"
@@ -5932,3 +5883,39 @@ msgstr "Vous ne pouvez plus écrire de commentaires, la date est passée."
 #, python-format
 msgid "Maximum characters: %(max_length)s"
 msgstr "Nombre de caractères max: %(max_length)s"
+
+#: eboutic/templates/eboutic/eboutic_main.jinja
+msgid "Eurockéennes 2025 partnership"
+msgstr "Partenariat Eurockéennes 2025"
+
+#: eboutic/templates/eboutic/eboutic_main.jinja
+msgid ""
+"Our partner uses Weezevent to sell tickets. Weezevent may collect user info "
+"according to its own privacy policy. By clicking the accept button you "
+"consent to their terms of services."
+msgstr ""
+"Notre partenaire utilises Wezevent pour vendre ses billets. Weezevent peut "
+"collecter des informations utilisateur conformément à sa propre politique de "
+"confidentialité. En cliquant sur le bouton d'acceptation vous consentez à "
+"leurs termes de service."
+
+#: eboutic/templates/eboutic/eboutic_main.jinja
+msgid "Privacy policy"
+msgstr "Politique de confidentialité"
+
+#: eboutic/templates/eboutic/eboutic_main.jinja
+msgid ""
+"You must be subscribed to benefit from the partnership with the Eurockéennes."
+msgstr ""
+"Vous devez être cotisant pour bénéficier du partenariat avec les "
+"Eurockéennes."
+
+#: eboutic/templates/eboutic/eboutic_main.jinja
+#, python-format
+msgid ""
+"This partnership offers a discount of up to 33%% on tickets for Friday, "
+"Saturday and Sunday, as well as the 3-day package from Friday to Sunday."
+msgstr ""
+"Ce partenariat permet de profiter d'une réduction jusqu'à 33%% sur les "
+"billets du vendredi, du samedi et du dimanche, ainsi qu'au forfait 3 jours, "
+"du vendredi au dimanche."

sas/forms.py

@@ -1,16 +1,22 @@
-from typing import Any
+from pathlib import Path
+from typing import TYPE_CHECKING, Any
 
 from django import forms
 from django.core.exceptions import ValidationError
 from django.utils.translation import gettext_lazy as _
+from PIL import Image
 
 from core.models import User
+from core.utils import resize_image
 from core.views import MultipleImageField
 from core.views.forms import SelectDate
 from core.views.widgets.ajax_select import AutoCompleteSelectMultipleGroup
 from sas.models import Album, Picture, PictureModerationRequest
 from sas.widgets.ajax_select import AutoCompleteSelectAlbum
 
+if TYPE_CHECKING:
+    from django.db.models.fields.files import FieldFile
+
 
 class AlbumCreateForm(forms.ModelForm):
     class Meta:
@@ -49,17 +55,30 @@ class AlbumEditForm(forms.ModelForm):
     class Meta:
         model = Album
         fields = ["name", "date", "file", "parent", "edit_groups"]
-        widgets = {
-            "edit_groups": AutoCompleteSelectMultipleGroup,
-        }
+        widgets = {"edit_groups": AutoCompleteSelectMultipleGroup, "date": SelectDate}
 
     name = forms.CharField(max_length=Album.NAME_MAX_LENGTH, label=_("file name"))
-    date = forms.DateField(label=_("Date"), widget=SelectDate, required=True)
     recursive = forms.BooleanField(label=_("Apply rights recursively"), required=False)
     parent = forms.ModelChoiceField(
         Album.objects.all(), required=True, widget=AutoCompleteSelectAlbum
     )
 
+    def clean_file(self):
+        # if a file was given in the form, resize it
+        f: FieldFile = self.cleaned_data["file"]
+        if self.errors or not f or "file" not in self.changed_data:
+            return f
+        f.file = resize_image(Image.open(f.file), 200, "WEBP")
+        return f
+
+    def save(self, commit=True):  # noqa: FBT002
+        if self.instance.file:
+            self.instance.file.name = str(Path(self.instance.name) / "thumb.webp")
+        self.instance = super().save(commit=commit)
+        if not self.instance.file:
+            self.instance.generate_thumbnail()
+        return self.instance
+
 
 class PictureModerationRequestForm(forms.ModelForm):
     """Form to create a PictureModerationRequest.
@@ -90,10 +109,3 @@ class PictureModerationRequestForm(forms.ModelForm):
         self.instance.author = self.user
         self.instance.picture = self.picture
         return super().save(commit)
-
-
-class PictureRotationForm(forms.Form):
-    picture = forms.ModelChoiceField(Picture.objects.all(), required=True)
-    direction = forms.ChoiceField(
-        choices=[("LEFT", _("Left")), ("RIGHT", _("Right"))], required=True
-    )

sas/models.py

@@ -110,7 +110,7 @@ class Picture(SasFile):
     def get_absolute_url(self):
         return reverse("sas:picture", kwargs={"picture_id": self.id})
 
-    def generate_thumbnails(self, *, overwrite=False):
+    def generate_thumbnails(self):
         im = Image.open(BytesIO(self.file.read()))
         with contextlib.suppress(Exception):
             im = exif_auto_rotate(im)
@@ -126,10 +126,6 @@ class Picture(SasFile):
         file = resize_image(im, max(im.size), extension, optimize=False)
         thumb = resize_image(im, 200, "webp")
         compressed = resize_image(im, 1200, "webp")
-        if overwrite:
-            self.file.delete()
-            self.thumbnail.delete()
-            self.compressed.delete()
         new_extension_name = str(Path(self.name).with_suffix(".webp"))
         self.file = file
         self.file.name = self.name
@@ -139,20 +135,20 @@ class Picture(SasFile):
         self.compressed.name = new_extension_name
 
     def rotate(self, degree):
-        im = Image.open(BytesIO(self.file.read()))
-        self.file.seek(0)
-        with open(self.file.path, "r+b") as f:
+        for attr in ["file", "compressed", "thumbnail"]:
+            name = self.__getattribute__(attr).name
+            with open(settings.MEDIA_ROOT / name, "r+b") as file:
+                if file:
+                    im = Image.open(BytesIO(file.read()))
+                    file.seek(0)
                     im = im.rotate(degree, expand=True)
                     im.save(
-                fp=f,
+                        fp=file,
                         format=self.mime_type.split("/")[-1].upper(),
                         quality=90,
                         optimize=True,
                         progressive=True,
                     )
-        self.file.seek(0)
-        self.generate_thumbnails(overwrite=True)
-        self.save()
 
     def get_next(self):
         if self.is_moderated:
@@ -245,17 +241,15 @@ class Album(SasFile):
         return reverse("sas:album_preview", kwargs={"album_id": self.id})
 
     def generate_thumbnail(self):
-        p = (
-            self.children_pictures.order_by("?").first()
-            or self.children_albums.exclude(file=None)
-            .exclude(file="")
+        p = self.children_pictures.order_by("?").first() or (
+            self.children_albums.exclude(Q(file=None) | Q(file=""))
             .order_by("?")
             .first()
         )
         if p and p.file:
             image = resize_image(Image.open(BytesIO(p.file.read())), 200, "webp")
             self.file = image
-            self.file.name = f"{self.name}/thumb.webp"
+            self.file.name = str(Path(self.name) / "thumb.webp")
             self.save()
 
 

sas/static/sas/css/picture.scss

@@ -134,7 +134,7 @@
           --loading-size: 20px
         }
 
-        @media (min-width: 700px) and (max-width: 1000px) {
+        @media (max-width: 1000px) {
           max-width: calc(50% - 5px);
         }
 
@@ -191,9 +191,7 @@
     }
 
     >form {
-
-      input,
-      .ts-wrapper {
+      input, .ts-wrapper {
         min-width: 100%;
         max-width: 100%;
         margin: 5px;
@@ -203,65 +201,57 @@
   }
 }
 
-#pict .general {
+.general {
   display: flex;
   flex-direction: row;
-  gap: 3em;
-  justify-content: space-evenly;
+  gap: 20px;
 
   @media (max-width: 1000px) {
-    gap: 1em;
     flex-direction: column;
   }
 
-  .infos,
-  .tools {
-    flex: 1;
+  >.infos {
     display: flex;
     flex-direction: column;
-    gap: .5em;
+    width: 50%;
 
-    @media (min-width: 700px) {
-      max-width: 350px;
-    }
-  }
-
-  .infos>div,
-  .tools>div>div {
-    display: flex;
-    flex-direction: column;
-    gap: .35em;
-  }
-
-  .tools>div,
-  >.infos>div>div {
+    >div>div {
       display: flex;
       flex-direction: row;
       justify-content: space-between;
+
+      >*:first-child {
+        min-width: 150px;
+
+        @media (max-width: 1000px) {
+          min-width: auto;
+        }
+      }
+    }
   }
 
   >.tools {
-    flex: 1;
-
-    >div>div {
-
-      >form {
-        margin: 0;
-        padding: 0;
     display: flex;
-      }
+    flex-direction: column;
+    width: 50%;
 
-      >a.btn,
-      >form>button {
+    >div {
+      display: flex;
+      flex-direction: row;
+      justify-content: space-between;
+
+      >div {
+        >a.button {
+          box-sizing: border-box;
           background-color: $primary-neutral-light-color;
           display: flex;
           justify-content: center;
           align-items: center;
-        padding: 0;
+          padding: 10px;
           color: black;
+          border-radius: 5px;
           width: 40px;
           height: 40px;
-        font-size: 20px;
 
           &:hover {
             background-color: #aaa;
@@ -278,9 +268,9 @@
 
         &.buttons {
           display: flex;
-        flex-direction: row;
           gap: 5px;
         }
       }
     }
+  }
 }

sas/templates/sas/macros.jinja

@@ -2,19 +2,19 @@
   <a href="{{ url('sas:album', album_id=a.id) }}">
     {% if a.file %}
       {% set img = a.get_download_url() %}
-      {% set src = a.name %}
+      {% set alt = a.name %}
     {% elif a.children.filter(is_folder=False, is_moderated=True).exists() %}
       {% set picture = a.children.filter(is_folder=False).first().as_picture %}
       {% set img = picture.get_download_thumb_url()  %}
-      {% set src = picture.name %}
+      {% set alt = picture.name %}
     {% else %}
       {% set img = static('core/img/sas.jpg') %}
-      {% set src = "sas.jpg" %}
+      {% set alt = "sas.jpg" %}
     {% endif %}
     <div
       class="album{% if not a.is_moderated %} not_moderated{% endif %}"
     >
-      <img src="{{ img }}" alt="{{ src }}" loading="lazy" />
+      <img src="{{ img }}" alt="{{ alt }}" loading="lazy" />
       {% if not a.is_moderated %}
         <div class="overlay">&nbsp;</div>
         <div class="text">{% trans %}To be moderated{% endtrans %}</div>

sas/templates/sas/main.jinja

@@ -12,17 +12,6 @@
   {% trans %}See all the photos taken during events organised by the AE.{% endtrans %}
 {%- endblock %}
 
-{% block metatags %}
-  <meta property="og:url" content="{{ request.build_absolute_uri() }}" />
-  <meta property="og:type" content="website" />
-  <meta property="og:title" content="Stock à souvenirs" />
-  <meta
-    property="og:description"
-    content="Retrouvez toutes les photos prises durant les événements organisés par l'AE."
-  />
-  <meta property="og:image" content="{{ request.build_absolute_uri(static("core/img/logo_no_text.png")) }}" />
-{% endblock %}
-
 {% set is_sas_admin = user.is_root or user.is_in_group(pk=settings.SITH_GROUP_SAS_ADMIN_ID) %}
 
 {% from "sas/macros.jinja" import display_album %}

sas/templates/sas/picture.jinja

@@ -118,35 +118,15 @@
                 <a class="text" :href="currentPicture.full_size_url">
                   {% trans %}HD version{% endtrans %}
                 </a>
-                <a class="text danger " :href="currentPicture.report_url">
+                <br>
+                <a class="text danger" :href="currentPicture.report_url">
                   {% trans %}Ask for removal{% endtrans %}
                 </a>
               </div>
-              <div class="buttons"
-              >
-                <a
-                  class="btn btn-no-text"
-                  :href="currentPicture.edit_url"
-                  x-show="{{ user.has_perm("sas.change_sasfile")|tojson }} || currentPicture.owner.id === {{ user.id }}"
-                >
-                  <i class="fa-regular fa-pen-to-square edit-action"></i>
-                </a>
-                <form method="post" action="{{ url("sas:picture_rotate") }}"
-                      x-show="{{ user.has_perm("sas.change_sasfile")|tojson}}"
-                >
-                  {% csrf_token %}
-                  <input type="hidden" name="picture" :value="currentPicture.id">
-                  <input type="hidden" name="direction" value="LEFT">
-                  <button><i class="fa-solid fa-rotate-left"></i></button>
-                </form>
-                <form method="post" action="{{ url("sas:picture_rotate") }}"
-                      x-show="{{ user.has_perm("sas.change_sasfile")|tojson}}"
-                >
-                  {% csrf_token %}
-                  <input type="hidden" name="picture" :value="currentPicture.id">
-                  <input type="hidden" name="direction" value="RIGHT">
-                  <button><i class="fa-solid fa-rotate-right"></i></button>
-                </form>
+              <div class="buttons">
+                <a class="button" :href="currentPicture.edit_url"><i class="fa-regular fa-pen-to-square edit-action"></i></a>
+                <a class="button" href="?rotate_left"><i class="fa-solid fa-rotate-left"></i></a>
+                <a class="button" href="?rotate_right"><i class="fa-solid fa-rotate-right"></i></a>
               </div>
             </div>
           </div>

sas/tests/test_views.py

@@ -12,19 +12,16 @@
 # OR WITHIN THE LOCAL FILE "LICENSE"
 #
 #
-from io import BytesIO
 from typing import Callable
 
 import pytest
 from bs4 import BeautifulSoup
 from django.conf import settings
 from django.core.cache import cache
-from django.core.files.base import ContentFile
 from django.test import Client, TestCase
 from django.urls import reverse
 from django.utils.timezone import localdate
 from model_bakery import baker
-from PIL import Image
 from pytest_django.asserts import assertHTMLEqual, assertInHTML, assertRedirects
 
 from core.baker_recipes import old_subscriber_user, subscriber_user
@@ -300,93 +297,6 @@ class TestAlbumEdit:
         assert localdate(album.date) == localdate()
 
 
-@pytest.mark.django_db
-class TestPictureRotation:
-    @pytest.fixture
-    def picture(self) -> Picture:
-        # Creating a fake image from scratch is painful
-        # One of the base image in the test set is good enough
-        return Picture.objects.get(name="sli.jpg")
-
-    def load_image(self, file: ContentFile) -> Image.Image:
-        file.seek(0)
-        im = Image.open(BytesIO(file.read()))
-        file.seek(0)
-        return im
-
-    @pytest.mark.parametrize(
-        "user",
-        [
-            None,
-            lambda: baker.make(User),
-            subscriber_user.make,
-            old_subscriber_user.make,
-        ],
-    )
-    def test_permission_denied(
-        self,
-        client: Client,
-        picture: Picture,
-        user: Callable[[], User] | None,
-    ):
-        if user:
-            client.force_login(user())
-
-        payload = {
-            "picture": picture.pk,
-            "direction": "LEFT",
-        }
-        url = reverse("sas:picture_rotate")
-        response = client.post(url, payload)
-        if user:
-            assert response.status_code == 403
-        else:
-            assertRedirects(
-                response,
-                reverse(
-                    "core:login",
-                    query={
-                        "next": url,
-                    },
-                ),
-            )
-
-    @pytest.mark.parametrize(
-        "user",
-        [
-            lambda: baker.make(User, is_superuser=True),
-            lambda: baker.make(
-                User, groups=[Group.objects.get(pk=settings.SITH_GROUP_SAS_ADMIN_ID)]
-            ),
-        ],
-    )
-    def test_rotation(
-        self,
-        client: Client,
-        picture: Picture,
-        user: Callable[[], User],
-    ):
-        client.force_login(user())
-
-        payload = {
-            "picture": picture.pk,
-            "direction": "LEFT",
-        }
-        response = client.post(reverse("sas:picture_rotate"), payload)
-        assertRedirects(
-            response, reverse("sas:picture", kwargs={"picture_id": picture.pk})
-        )
-
-        payload = {
-            "picture": picture.pk,
-            "direction": "RIGHT",
-        }
-        response = client.post(reverse("sas:picture_rotate"), payload)
-        assertRedirects(
-            response, reverse("sas:picture", kwargs={"picture_id": picture.pk})
-        )
-
-
 class TestSasModeration(TestCase):
     @classmethod
     def setUpTestData(cls):

sas/urls.py

@@ -22,7 +22,6 @@ from sas.views import (
     ModerationView,
     PictureAskRemovalView,
     PictureEditView,
-    PictureRotateView,
     PictureView,
     SASMainView,
     UserPicturesView,
@@ -53,7 +52,6 @@ urlpatterns = [
         send_compressed,
         name="download_compressed",
     ),
-    path("picture/rotate", PictureRotateView.as_view(), name="picture_rotate"),
     path("picture/<int:picture_id>/download/thumb/", send_thumb, name="download_thumb"),
     path(
         "user/<int:user_id>/pictures/", UserPicturesView.as_view(), name="user_pictures"

sas/views.py

@@ -15,14 +15,13 @@
 from typing import Any
 
 from django.conf import settings
-from django.contrib import messages
 from django.contrib.auth.mixins import PermissionRequiredMixin
+from django.core.exceptions import PermissionDenied
 from django.db.models import Count, OuterRef, Subquery
 from django.http import Http404, HttpResponseRedirect
 from django.shortcuts import get_object_or_404, redirect
 from django.urls import reverse
 from django.utils.safestring import SafeString
-from django.utils.translation import gettext_lazy as _
 from django.views.generic import CreateView, DetailView, TemplateView
 from django.views.generic.edit import FormView, UpdateView
 
@@ -37,7 +36,6 @@ from sas.forms import (
     AlbumEditForm,
     PictureEditForm,
     PictureModerationRequestForm,
-    PictureRotationForm,
     PictureUploadForm,
 )
 from sas.models import Album, PeoplePictureRelation, Picture
@@ -99,39 +97,20 @@ class PictureView(CanViewMixin, DetailView):
     pk_url_kwarg = "picture_id"
     template_name = "sas/picture.jinja"
 
+    def get(self, request, *args, **kwargs):
+        self.object = self.get_object()
+        if "rotate_right" in request.GET:
+            self.object.rotate(270)
+        if "rotate_left" in request.GET:
+            self.object.rotate(90)
+        return super().get(request, *args, **kwargs)
+
     def get_context_data(self, **kwargs):
         return super().get_context_data(**kwargs) | {
             "album": Album.objects.get(children=self.object)
         }
 
 
-class PictureRotateView(PermissionRequiredMixin, FormView):
-    form_class = PictureRotationForm
-    template_name = "core/edit.jinja"
-    permission_required = "sas.moderate_sasfile"
-
-    def form_valid(self, form: PictureRotationForm):
-        angles = {"RIGHT": 270, "LEFT": 90}
-        cleaned = form.clean()
-        cleaned["picture"].rotate(angles[cleaned["direction"]])
-        self._success_url = reverse(
-            "sas:picture",
-            kwargs={
-                "picture_id": cleaned["picture"].pk,
-            },
-        )
-        messages.warning(
-            self.request,
-            _(
-                "Newly rotated image might not be immediately displayed due to your web browser's cache"
-            ),
-        )
-        return super().form_valid(form)
-
-    def get_success_url(self):
-        return self._success_url
-
-
 def send_album(request, album_id):
     return send_file(request, album_id, Album)
 
@@ -174,9 +153,8 @@ class AlbumView(CanViewMixin, UseFragmentsMixin, DetailView):
 
     def post(self, request, *args, **kwargs):
         self.object = self.get_object()
-        if not self.object.file:
-            self.object.generate_thumbnail()
-        if request.user.can_edit(self.object):  # Handle the copy-paste functions
+        if not request.user.can_edit(self.object):
+            raise PermissionDenied
         FileView.handle_clipboard(request, self.object)
         return HttpResponseRedirect(self.request.path)