ts-ify guide-index.ts

club/templates/club/club_list.jinja

@@ -15,6 +15,9 @@
   {% endblock %}
 {% else %}
   {% extends "core/base.jinja" %}
+  {% block additional_css %}
+    <link rel="stylesheet" href="{{ static("club/list.scss") }}">
+  {% endblock %}
   {% block description -%}
     {% trans %}The list of all clubs existing at UTBM.{% endtrans %}
   {%- endblock %}
@@ -23,12 +26,6 @@
   {%- endblock %}
 {% endif %}
 
-{% block additional_css %}
-  {% if not is_fragment %}
-    <link rel="stylesheet" href="{{ static("club/list.scss") }}">
-  {% endif %}
-{% endblock %}
-
 {% from "core/macros.jinja" import paginate_htmx %}
 
 {% block content %}
@@ -36,17 +33,15 @@
     <h3>{% trans %}Filters{% endtrans %}</h3>
     <form
       id="club-list-filters"
-      method="GET"
+      hx-get="{{ url("club:club_list") }}"
-      hx-action="{{ url("club:club_list") }}"
       hx-target="#content"
-      hx-swap="innerHTML"
+      hx-swap="outerHtml"
       hx-push-url="true"
-      hx-disable="find input, find button"
     >
       <div class="row gap-4x">
         {{ form }}
       </div>
-      <button class="btn btn-blue margin-bottom">
+      <button type="submit" class="btn btn-blue margin-bottom">
         <i class="fa fa-magnifying-glass"></i>{% trans %}Search{% endtrans %}
       </button>
     </form>

core/static/bundled/base-bundle-index.ts

@@ -62,7 +62,6 @@ document.body.addEventListener(
   },
 );
 
-htmx.config.transitions = true;
 Object.assign(window, { htmx });
 
 /**

core/templates/core/file_delete_confirm.jinja

@@ -31,7 +31,7 @@
       {% if is_fragment %}
         hx-post="{{ action }}"
         hx-target="#content"
-        hx-swap="innerHTML"
+        hx-swap="outerHtml"
       {% endif %}
     >{% trans %}Confirm{% endtrans %}</button>
 
@@ -39,7 +39,7 @@
       {% if is_fragment %}
         hx-get="{{ previous }}"
         hx-target="#content"
-        hx-swap="innerHTML"
+        hx-swap="outerHtml"
       {% else %}
         action="window.history.back()"
       {% endif %}

core/templates/core/file_moderation.jinja

@@ -39,13 +39,13 @@
         <p><button
           hx-get="{{ url('core:file_moderate', file_id=f.id) }}"
           hx-target="#content"
-          hx-swap="innerHTML"
+          hx-swap="outerHtml"
         >{% trans %}Moderate{% endtrans %}</button> -
           {% set current_page = url('core:file_moderation') + "?page=" + page_obj.number | string %}
           <button
             hx-get="{{ url('core:file_delete', file_id=f.id) }}?next={{ current_page | urlencode }}&previous={{ current_page | urlencode }}"
             hx-target="#file-{{ loop.index }}"
-            hx-swap="innerHTML"
+            hx-swap="outerHtml"
           >{% trans %}Delete{% endtrans %}</button></p>
       </div>
     {% endfor %}

pedagogy/static/bundled/pedagogy/guide-index.ts

@@ -1,9 +1,5 @@
-import {
+import { getCurrentUrlParams, updateQueryString } from "#core:utils/history";
-  getCurrentUrlParams,
+import { type SimpleUeSchema, ueFetchUeList } from "#openapi";
-  History,
-  updateQueryString,
-} from "#core:utils/history.ts";
-import { ueFetchUeList } from "#openapi";
 
 const pageDefault = 1;
 const pageSizeDefault = 100;
@@ -12,38 +8,42 @@ document.addEventListener("alpine:init", () => {
   Alpine.data("ue_search", () => ({
     ues: {
       count: 0,
-      next: null,
+      next: null as string | null,
-      previous: null,
+      previous: null as string | null,
-      results: [],
+      results: [] as SimpleUeSchema[],
     },
     loading: false,
     page: pageDefault,
     // biome-ignore lint/style/useNamingConvention: api is in snake_case
     page_size: pageSizeDefault,
     search: "",
-    department: [],
+    department: [] as string[],
     // biome-ignore lint/style/useNamingConvention: api is in snake_case
-    credit_type: [],
+    credit_type: [] as string[],
-    semester: [],
+    semester: [] as string[],
     // biome-ignore lint/style/useNamingConvention: api is in snake_case
-    to_change: [],
+    to_change: [] as { param: string; value: string }[],
-    pushstate: History.Push,
 
-    update: undefined,
+    // dummy implementation to make TS happy.
+    // The real function is initialized in init
+    update: () => {
+      console.warn("Update not yet initialized");
+    },
 
     initializeArgs() {
       const url = getCurrentUrlParams();
-      this.pushstate = History.Replace;
+      this.page = Number.parseInt(url.get("page") || pageDefault.toString(), 10);
-
+      this.page_size = Number.parseInt(
-      this.page = Number.parseInt(url.get("page"), 10) || pageDefault;
+        url.get("page_size") || pageSizeDefault.toString(),
-      this.page_size = Number.parseInt(url.get("page_size"), 10) || pageSizeDefault;
+        10,
+      );
       this.search = url.get("search") || "";
       this.department = url.getAll("department");
       this.credit_type = url.getAll("credit_type");
       /* The semester is easier to use on the backend as an enum (spring/autumn/both/none)
           and easier to use on the frontend as an array ([spring, autumn]).
           Thus there is some conversion involved when both communicate together */
-      this.semester = url.has("semester") ? url.get("semester").split("_AND_") : [];
+      this.semester = url.get("semester")?.split("_AND_") || [];
 
       this.update();
     },
@@ -51,15 +51,11 @@ document.addEventListener("alpine:init", () => {
     async init() {
       this.update = Alpine.debounce(async () => {
         /* Create the whole url before changing everything all at once */
-        const first = this.to_change.shift();
+        for (const val of this.to_change) {
-        let url = updateQueryString(first.param, first.value, History.None);
+          updateQueryString(val.param, val.value);
-        for (const value of this.to_change) {
-          url = updateQueryString(value.param, value.value, History.None, url);
         }
-        updateQueryString(first.param, first.value, this.pushstate, url);
         await this.fetchData(); /* reload data on form change */
         this.to_change = [];
-        this.pushstate = History.Push;
       }, 50);
 
       const searchParams = ["search", "department", "credit_type", "semester"];
@@ -67,47 +63,37 @@ document.addEventListener("alpine:init", () => {
 
       for (const param of searchParams) {
         this.$watch(param, () => {
-          if (this.pushstate !== History.Push) {
-            /* This means that we are doing a mass param edit */
-            return;
-          }
           /* Reset pagination on search */
           this.page = pageDefault;
           this.page_size = pageSizeDefault;
         });
       }
       for (const param of searchParams.concat(paginationParams)) {
-        this.$watch(param, (value) => {
+        this.$watch(param, (value: string) => {
           this.to_change.push({ param: param, value: value });
           this.update();
         });
       }
-      window.addEventListener("popstate", () => {
-        this.initializeArgs();
-      });
       this.initializeArgs();
     },
 
     async fetchData() {
       this.loading = true;
-      const args = {
+
-        // biome-ignore lint/style/useNamingConvention: api is in snake_case
+      const res = await ueFetchUeList({
-        page_size: this.page_size,
+        query: {
-      };
+          // biome-ignore lint/style/useNamingConvention: api is in snake_case
-      for (const [param, value] of new URL(
+          page_size: this.page_size,
-        window.location.href,
+          // biome-ignore lint/style/useNamingConvention: api is in snake_case
-      ).searchParams.entries()) {
+          credit_type: this.credit_type.length > 0 ? this.credit_type : undefined,
-        // Deal with array type params
+          semester: this.semester.length > 0 ? this.semester : undefined,
-        if (["credit_type", "department", "semester"].includes(param)) {
+          department: this.department.length > 0 ? this.department : undefined,
-          if (args[param] === undefined) {
+          search: this.search || undefined,
-            args[param] = [];
+        },
-          }
+      });
-          args[param].push(value);
+      if (res.data !== undefined) {
-        } else {
+        this.ues = res.data;
-          args[param] = value;
-        }
       }
-      this.ues = (await ueFetchUeList({ query: args })).data;
       this.loading = false;
     },