klmp200/Sith
1
0
Fork 0
mirror of https://github.com/ae-utbm/sith.git synced 2026-04-18 01:08:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

add tests

Browse Source
This commit is contained in:
imperosol
2026-04-17 18:13:13 +02:00
parent 5250751d77
commit fed0905b9c
6 changed files with 226 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
club/models.py
View File

@@ -208,7 +208,9 @@ class Club(models.Model):
"""Return True if the given user can edit the roles of this club"""
return (
user.has_perm("club.change_clubrole")
or self.members.ongoing().filter(user=user, role__is_presidency=True).exists()
or self.members.ongoing()
.filter(user=user, role__is_presidency=True)
.exists()
)
@cached_property
@@ -258,6 +260,9 @@ class ClubRole(OrderedModel):
models.CheckConstraint(
condition=Q(is_presidency=False) | Q(is_board=True),
name="clubrole_presidency_implies_board",
violation_error_message=_(
"A role cannot be in the presidency while not being in the board"
),
)
]
@@ -267,26 +272,13 @@ class ClubRole(OrderedModel):
def get_display_name(self):
return f"{self.name} - {self.club.name}"
def get_absolute_url(self):
return reverse("club:club_roles", kwargs={"club_id": self.club_id})
def clean(self):
errors = []
if self.is_presidency and not self.is_board:
errors.append(
ValidationError(
_(
"Role %(name)s was declared as a presidency role "
"without being a board role"
)
% {"name": self.name}
)
)
roles = list(self.club.roles.all())
if (
self.is_board
and self.order
and any(r.order < self.order and not r.is_board for r in roles)
and any(r.order <= self.order and not r.is_board for r in roles)
):
errors.append(
ValidationError(
@@ -297,7 +289,7 @@ class ClubRole(OrderedModel):
if (
self.is_presidency
and self.order
and any(r.order < self.order and not r.is_presidency for r in roles)
and any(r.order <= self.order and not r.is_presidency for r in roles)
):
errors.append(
ValidationError(