add forgotten check

club/models.py

@@ -245,7 +245,6 @@ class ClubRole(OrderedModel):
     class Meta(OrderedModel.Meta):
         verbose_name = _("club role")
         verbose_name_plural = _("club roles")
-        abstract = False
         constraints = [
             # presidency IMPLIES board <=> NOT presidency OR board
             # cf. MT1 :)
@@ -276,14 +275,26 @@ class ClubRole(OrderedModel):
                     % {"name": self.name}
                 )
             )
+        roles = list(self.club.roles.all())
         if (
             self.is_board
             and self.order
-            and self.club.roles.filter(is_board=False, order__lt=self.order).exists()
+            and any(r.order < self.order and not r.is_board for r in roles)
         ):
             errors.append(
                 ValidationError(
-                    _("Board role %(role)s cannot be placed below a member role")
+                    _("Role %(role)s cannot be placed below a member role")
+                    % {"role": self.name}
+                )
+            )
+        if (
+            self.is_presidency
+            and self.order
+            and any(r.order < self.order and not r.is_presidency for r in roles)
+        ):
+            errors.append(
+                ValidationError(
+                    _("Role %(role)s cannot be placed below a non-presidency role")
                     % {"role": self.name}
                 )
             )

club/tests/test_clubrole.py

@@ -10,7 +10,7 @@ def test_order_auto():
     """Test that newly created roles are put in the right place."""
     club = baker.make(Club)
     recipe = Recipe(ClubRole, club=club, name=seq("role "))
-    # bulk create initial roles
+    # bulk create initial roles (1 presidency, 1 board, 1 member)
     roles = recipe.make(
         is_board=iter([True, True, False]),
         is_presidency=iter([True, False, False]),