klmp200/Sith
1
0
Fork 0
mirror of https://github.com/ae-utbm/sith.git synced 2025-04-16 02:50:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix account creation view tests

Browse Source
This commit is contained in:
Thomas Girod 2025-04-11 14:35:57 +02:00
parent 64085ac2a4
commit f4276d6be5
2 changed files with 15 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
antispam/forms.py
View File

@ -1,5 +1,3 @@
import re
from django import forms from django import forms
from django.core.validators import EmailValidator from django.core.validators import EmailValidator
from django.utils.translation import gettext_lazy as _ from django.utils.translation import gettext_lazy as _
@ -7,12 +5,18 @@ from django.utils.translation import gettext_lazy as _
from antispam.models import ToxicDomain from antispam.models import ToxicDomain
class AntiSpamEmailValidator(EmailValidator):
def __call__(self, value: str):
super().__call__(value)
domain_part = value.rsplit("@", 1)[1]
if ToxicDomain.objects.filter(domain=domain_part).exists():
raise forms.ValidationError(_("Email domain is not allowed."))
validate_antispam_email = AntiSpamEmailValidator()
class AntiSpamEmailField(forms.EmailField): class AntiSpamEmailField(forms.EmailField):
"""An email field that email addresses with a known toxic domain.""" """An email field that email addresses with a known toxic domain."""
def run_validators(self, value: str): default_validators = [validate_antispam_email]
super().run_validators(value)
# Domain part should exist since email validation is guaranteed to run first
domain = re.search(EmailValidator.domain_regex, value)
if ToxicDomain.objects.filter(domain=domain[0]).exists():
raise forms.ValidationError(_("Email domain is not allowed."))

5
core/tests/test_core.py
View File

@ -100,8 +100,9 @@ class TestUserRegistration:
payload = valid_payload | payload_edit payload = valid_payload | payload_edit
response = client.post(reverse("core:register"), payload) response = client.post(reverse("core:register"), payload)
assert response.status_code == 200 assert response.status_code == 200
error_html = f'<ul class="errorlist"><li>{expected_error}</li></ul>' errors = BeautifulSoup(response.text, "lxml").find_all(class_="errorlist")
assertInHTML(error_html, str(response.content.decode())) assert len(errors) == 1
assert errors[0].text == expected_error
assert not User.objects.filter(email=payload["email"]).exists() assert not User.objects.filter(email=payload["email"]).exists()
def test_register_honeypot_fail(self, client: Client, valid_payload): def test_register_honeypot_fail(self, client: Client, valid_payload):