klmp200/Sith
1
0
Fork 0
mirror of https://github.com/ae-utbm/sith.git synced 2025-07-10 20:09:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add more Ruff rules (#891)

Browse Source 
* ruff: apply rule F

* ruff: apply rule E

* ruff: apply rule SIM

* ruff: apply rule TCH

* ruff: apply rule ERA

* ruff: apply rule PLW

* ruff: apply rule FLY

* ruff: apply rule PERF

* ruff: apply rules FURB & RUF
This commit is contained in:
thomas girod
2024-10-15 11:36:26 +02:00
committed by GitHub
parent d114b01bcc
commit d16a207a83
82 changed files with 836 additions and 748 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
trombi/views.py
View File

@ -29,6 +29,7 @@ from django import forms
from django.conf import settings
from django.contrib.auth.mixins import LoginRequiredMixin
from django.core.exceptions import PermissionDenied
from django.db import IntegrityError
from django.forms.models import modelform_factory
from django.http import Http404, HttpResponseRedirect
from django.shortcuts import get_object_or_404, redirect
@ -75,7 +76,10 @@ class TrombiTabsMixin(TabedViewMixin):
"name": _("My pictures"),
}
)
try:
if (
hasattr(self.request.user, "trombi_user")
and self.request.user.trombi_user.trombi
):
trombi = self.request.user.trombi_user.trombi
if self.request.user.is_owner(trombi):
tab_list.append(
@ -87,8 +91,6 @@ class TrombiTabsMixin(TabedViewMixin):
"name": _("Admin tools"),
}
)
except:
pass
return tab_list
@ -163,7 +165,7 @@ class TrombiDetailView(CanEditMixin, QuickNotifMixin, TrombiTabsMixin, DetailVie
try:
TrombiUser(user=form.cleaned_data["user"], trombi=self.object).save()
self.quick_notif_list.append("qn_success")
except: # We don't care about duplicate keys
except IntegrityError: # We don't care about duplicate keys
self.quick_notif_list.append("qn_fail")
return super().get(request, *args, **kwargs)
@ -239,12 +241,12 @@ class TrombiModerateCommentView(DetailView):
)
elif request.POST["action"] == "reject":
return super().get(request, *args, **kwargs)
elif request.POST["action"] == "delete" and "reason" in request.POST.keys():
elif request.POST["action"] == "delete" and "reason" in request.POST:
self.object.author.user.email_user(
subject="[%s] %s" % (settings.SITH_NAME, _("Rejected comment")),
message=_(
'Your comment to %(target)s on the Trombi "%(trombi)s" was rejected for the following '
"reason: %(reason)s\n\n"
'Your comment to %(target)s on the Trombi "%(trombi)s" '
"was rejected for the following reason: %(reason)s\n\n"
"Your comment was:\n\n%(content)s"
)
% {
@ -498,7 +500,7 @@ class TrombiCommentFormView(LoginRequiredMixin, View):
def get_context_data(self, **kwargs):
kwargs = super().get_context_data(**kwargs)
if "user_id" in self.kwargs.keys():
if "user_id" in self.kwargs:
kwargs["target"] = get_object_or_404(TrombiUser, id=self.kwargs["user_id"])
else:
kwargs["target"] = self.object.target