ruff rules UP008 and UP009

counter/__init__.py

@@ -1,4 +1,3 @@
-# -*- coding:utf-8 -*
 #
 # Copyright 2016,2017,2019
 # - Skia <skia@libskia.so>

counter/admin.py

@@ -1,4 +1,3 @@
-# -*- coding:utf-8 -*
 #
 # Copyright 2023 © AE UTBM
 # ae@utbm.fr / ae.info@utbm.fr

counter/app.py

@@ -1,4 +1,3 @@
-# -*- coding:utf-8 -*
 #
 # Copyright 2019
 # - Sli <antoine@bartuccio.fr>

counter/forms.py

@@ -32,7 +32,7 @@ class StudentCardForm(forms.ModelForm):
         fields = ["uid"]
 
     def clean(self):
-        cleaned_data = super(StudentCardForm, self).clean()
+        cleaned_data = super().clean()
         uid = cleaned_data.get("uid", None)
         if not uid or not StudentCard.is_valid(uid):
             raise forms.ValidationError(_("This UID is invalid"), code="invalid")
@@ -57,10 +57,10 @@ class GetUserForm(forms.Form):
 
     def as_p(self):
         self.fields["code"].widget.attrs["autofocus"] = True
-        return super(GetUserForm, self).as_p()
+        return super().as_p()
 
     def clean(self):
-        cleaned_data = super(GetUserForm, self).clean()
+        cleaned_data = super().clean()
         cus = None
         if cleaned_data["code"] != "":
             if len(cleaned_data["code"]) == StudentCard.UID_SIZE:
@@ -141,14 +141,14 @@ class ProductEditForm(forms.ModelForm):
     )
 
     def __init__(self, *args, **kwargs):
-        super(ProductEditForm, self).__init__(*args, **kwargs)
+        super().__init__(*args, **kwargs)
         if self.instance.id:
             self.fields["counters"].initial = [
                 str(c.id) for c in self.instance.counters.all()
             ]
 
     def save(self, *args, **kwargs):
-        ret = super(ProductEditForm, self).save(*args, **kwargs)
+        ret = super().save(*args, **kwargs)
         if self.fields["counters"].initial:
             for cid in self.fields["counters"].initial:
                 c = Counter.objects.filter(id=int(cid)).first()

counter/migrations/0001_initial.py

@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-
 from __future__ import unicode_literals
 
 import django.db.models.deletion

counter/migrations/0002_auto_20160826_1342.py

@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-
 from __future__ import unicode_literals
 
 import django.db.models.deletion

counter/migrations/0003_permanency_activity.py

@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-
 from __future__ import unicode_literals
 
 import datetime

counter/migrations/0004_auto_20160826_1907.py

@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-
 from __future__ import unicode_literals
 
 from django.db import migrations, models

counter/migrations/0005_auto_20160826_2330.py

@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-
 from __future__ import unicode_literals
 
 import django.db.models.deletion

counter/migrations/0006_auto_20160831_1304.py

@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-
 from __future__ import unicode_literals
 
 from django.db import migrations, models

counter/migrations/0007_product_archived.py

@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-
 from __future__ import unicode_literals
 
 from django.db import migrations, models

counter/migrations/0008_counter_token.py

@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-
 from __future__ import unicode_literals
 
 from django.db import migrations, models

counter/migrations/0009_eticket.py

@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-
 from __future__ import unicode_literals
 
 import django.db.models.deletion

counter/migrations/0010_auto_20161003_1900.py

@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-
 from __future__ import unicode_literals
 
 from django.db import migrations, models

counter/migrations/0011_auto_20161004_2039.py

@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-
 from __future__ import unicode_literals
 
 from django.db import migrations, models

counter/migrations/0012_auto_20170515_2202.py

@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-
 from __future__ import unicode_literals
 
 from django.db import migrations, models

counter/migrations/0013_customer_recorded_products.py

@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-
 from __future__ import unicode_literals
 
 from django.conf import settings

counter/migrations/0014_auto_20170816_1521.py

@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-
 from __future__ import unicode_literals
 
 from django.db import migrations, models

counter/migrations/0014_auto_20170817_1537.py

@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-
 from __future__ import unicode_literals
 
 from django.db import migrations, models

counter/migrations/0015_merge.py

@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-
 from __future__ import unicode_literals
 
 from django.db import migrations

counter/migrations/0016_producttype_comment.py

@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-
 from __future__ import unicode_literals
 
 from django.db import migrations, models

counter/migrations/0017_studentcard.py

@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-
 # Generated by Django 1.11.13 on 2018-10-18 23:15
 from __future__ import unicode_literals
 

counter/models.py

@@ -1,4 +1,3 @@
-# -*- coding:utf-8 -*
 #
 # Copyright 2023 © AE UTBM
 # ae@utbm.fr / ae.info@utbm.fr
@@ -137,7 +136,7 @@ class Customer(models.Model):
         """
         if self.amount < 0 and (is_selling and not allow_negative):
             raise ValidationError(_("Not enough money"))
-        super(Customer, self).save(*args, **kwargs)
+        super().save(*args, **kwargs)
 
     def recompute_amount(self):
         refillings = self.refillings.aggregate(sum=Sum(F("amount")))["sum"]
@@ -638,7 +637,7 @@ class Refilling(models.Model):
     def delete(self, *args, **kwargs):
         self.customer.amount -= self.amount
         self.customer.save()
-        super(Refilling, self).delete(*args, **kwargs)
+        super().delete(*args, **kwargs)
 
     def save(self, *args, **kwargs):
         if not self.date:
@@ -662,7 +661,7 @@ class Refilling(models.Model):
                 param=str(self.amount),
                 type="REFILLING",
             ).save()
-        super(Refilling, self).save(*args, **kwargs)
+        super().save(*args, **kwargs)
 
 
 class Selling(models.Model):
@@ -740,7 +739,7 @@ class Selling(models.Model):
         if self.payment_method == "SITH_ACCOUNT":
             self.customer.amount += self.quantity * self.unit_price
             self.customer.save()
-        super(Selling, self).delete(*args, **kwargs)
+        super().delete(*args, **kwargs)
 
     def send_mail_customer(self):
         event = self.product.eticket.event_title or _("Unknown event")
@@ -851,7 +850,7 @@ class Selling(models.Model):
                 param="%d x %s" % (self.quantity, self.label),
                 type="SELLING",
             ).save()
-        super(Selling, self).save(*args, **kwargs)
+        super().save(*args, **kwargs)
         try:
             # The product has no id until it's saved
             if self.product.eticket:
@@ -982,7 +981,7 @@ class CashRegisterSummary(models.Model):
     def save(self, *args, **kwargs):
         if not self.id:
             self.date = timezone.now()
-        return super(CashRegisterSummary, self).save(*args, **kwargs)
+        return super().save(*args, **kwargs)
 
     def get_absolute_url(self):
         return reverse("counter:cash_summary_list")
@@ -1036,7 +1035,7 @@ class Eticket(models.Model):
     def save(self, *args, **kwargs):
         if not self.id:
             self.secret = base64.b64encode(os.urandom(32))
-        return super(Eticket, self).save(*args, **kwargs)
+        return super().save(*args, **kwargs)
 
     def is_owned_by(self, user):
         """

counter/signals.py

@@ -1,4 +1,3 @@
-# -*- coding:utf-8 -*
 #
 # Copyright 2019
 # - Sli <antoine@bartuccio.fr>

counter/tests.py

@@ -1,4 +1,3 @@
-# -*- coding:utf-8 -*
 #
 # Copyright 2023 © AE UTBM
 # ae@utbm.fr / ae.info@utbm.fr

counter/urls.py

@@ -1,4 +1,3 @@
-# -*- coding:utf-8 -*
 #
 # Copyright 2023 © AE UTBM
 # ae@utbm.fr / ae.info@utbm.fr

counter/views.py

@@ -1,4 +1,3 @@
-# -*- coding:utf-8 -*
 #
 # Copyright 2023 © AE UTBM
 # ae@utbm.fr / ae.info@utbm.fr
@@ -102,7 +101,7 @@ class CounterAdminMixin(View):
             or self._test_club(request.user)
         ):
             raise PermissionDenied
-        return super(CounterAdminMixin, self).dispatch(request, *args, **kwargs)
+        return super().dispatch(request, *args, **kwargs)
 
 
 class StudentCardDeleteView(DeleteView, CanEditMixin):
@@ -116,7 +115,7 @@ class StudentCardDeleteView(DeleteView, CanEditMixin):
 
     def dispatch(self, request, *args, **kwargs):
         self.customer = get_object_or_404(Customer, pk=kwargs["customer_id"])
-        return super(StudentCardDeleteView, self).dispatch(request, *args, **kwargs)
+        return super().dispatch(request, *args, **kwargs)
 
     def get_success_url(self, **kwargs):
         return reverse_lazy(
@@ -237,7 +236,7 @@ class CounterMain(
                 )
                 + "?bad_location"
             )
-        return super(CounterMain, self).post(request, *args, **kwargs)
+        return super().post(request, *args, **kwargs)
 
     def get_context_data(self, **kwargs):
         """
@@ -246,7 +245,7 @@ class CounterMain(
         if self.request.method == "POST":
             self.object = self.get_object()
         self.object.update_activity()
-        kwargs = super(CounterMain, self).get_context_data(**kwargs)
+        kwargs = super().get_context_data(**kwargs)
         kwargs["login_form"] = LoginForm()
         kwargs["login_form"].fields["username"].widget.attrs["autofocus"] = True
         kwargs[
@@ -280,7 +279,7 @@ class CounterMain(
         We handle here the redirection, passing the user id of the asked customer
         """
         self.kwargs["user_id"] = form.cleaned_data["user_id"]
-        return super(CounterMain, self).form_valid(form)
+        return super().form_valid(form)
 
     def get_success_url(self):
         return reverse_lazy("counter:click", args=self.args, kwargs=self.kwargs)
@@ -345,7 +344,7 @@ class CounterClick(CounterTabsMixin, CanViewMixin, DetailView):
         else:
             if not request.user.is_authenticated:
                 raise PermissionDenied
-        return super(CounterClick, self).dispatch(request, *args, **kwargs)
+        return super().dispatch(request, *args, **kwargs)
 
     def get(self, request, *args, **kwargs):
         """Simple get view"""
@@ -357,7 +356,7 @@ class CounterClick(CounterTabsMixin, CanViewMixin, DetailView):
         request.session["not_allowed"] = False
         request.session["no_age"] = False
         self.refill_form = None
-        ret = super(CounterClick, self).get(request, *args, **kwargs)
+        ret = super().get(request, *args, **kwargs)
         if (self.object.type != "BAR" and not request.user.is_authenticated) or (
             self.object.type == "BAR" and len(self.object.get_barmen_list()) < 1
         ):  # Check that at least one barman is logged in
@@ -680,7 +679,7 @@ class CounterClick(CounterTabsMixin, CanViewMixin, DetailView):
 
     def get_context_data(self, **kwargs):
         """Add customer to the context"""
-        kwargs = super(CounterClick, self).get_context_data(**kwargs)
+        kwargs = super().get_context_data(**kwargs)
         products = self.object.products.select_related("product_type")
         if self.customer_is_barman():
             products = products.annotate(price=F("special_selling_price"))
@@ -732,7 +731,7 @@ class CounterLogin(RedirectView):
                 self.errors += ["sellers"]
         else:
             self.errors += ["credentials"]
-        return super(CounterLogin, self).post(request, *args, **kwargs)
+        return super().post(request, *args, **kwargs)
 
     def get_redirect_url(self, *args, **kwargs):
         return (
@@ -752,7 +751,7 @@ class CounterLogout(RedirectView):
         self.counter = Counter.objects.filter(id=kwargs["counter_id"]).first()
         user = User.objects.filter(id=request.POST["user_id"]).first()
         self.counter.del_barman(user)
-        return super(CounterLogout, self).post(request, *args, **kwargs)
+        return super().post(request, *args, **kwargs)
 
     def get_redirect_url(self, *args, **kwargs):
         return reverse_lazy("counter:details", args=args, kwargs=kwargs)
@@ -827,7 +826,7 @@ class CounterEditView(CounterAdminTabsMixin, CounterAdminMixin, UpdateView):
     def dispatch(self, request, *args, **kwargs):
         obj = self.get_object()
         self.edit_club.append(obj.club)
-        return super(CounterEditView, self).dispatch(request, *args, **kwargs)
+        return super().dispatch(request, *args, **kwargs)
 
     def get_success_url(self):
         return reverse_lazy("counter:admin", kwargs={"counter_id": self.object.id})
@@ -981,12 +980,12 @@ class RefillingDeleteView(DeleteView):
             self.success_url = reverse(
                 "counter:details", kwargs={"counter_id": self.object.counter.id}
             )
-            return super(RefillingDeleteView, self).dispatch(request, *args, **kwargs)
+            return super().dispatch(request, *args, **kwargs)
         elif self.object.is_owned_by(request.user):
             self.success_url = reverse(
                 "core:user_account", kwargs={"user_id": self.object.customer.user.id}
             )
-            return super(RefillingDeleteView, self).dispatch(request, *args, **kwargs)
+            return super().dispatch(request, *args, **kwargs)
         raise PermissionDenied
 
 
@@ -1016,12 +1015,12 @@ class SellingDeleteView(DeleteView):
             self.success_url = reverse(
                 "counter:details", kwargs={"counter_id": self.object.counter.id}
             )
-            return super(SellingDeleteView, self).dispatch(request, *args, **kwargs)
+            return super().dispatch(request, *args, **kwargs)
         elif self.object.is_owned_by(request.user):
             self.success_url = reverse(
                 "core:user_account", kwargs={"user_id": self.object.customer.user.id}
             )
-            return super(SellingDeleteView, self).dispatch(request, *args, **kwargs)
+            return super().dispatch(request, *args, **kwargs)
         raise PermissionDenied
 
 
@@ -1080,7 +1079,7 @@ class CashRegisterSummaryForm(forms.Form):
 
     def __init__(self, *args, **kwargs):
         instance = kwargs.pop("instance", None)
-        super(CashRegisterSummaryForm, self).__init__(*args, **kwargs)
+        super().__init__(*args, **kwargs)
         if instance:
             self.fields["ten_cents"].initial = (
                 instance.ten_cents.quantity if instance.ten_cents else 0
@@ -1261,9 +1260,7 @@ class CounterLastOperationsView(CounterTabsMixin, CanViewMixin, DetailView):
                 token=request.session["counter_token"]
             ).exists()
         ):
-            return super(CounterLastOperationsView, self).dispatch(
-                request, *args, **kwargs
-            )
+            return super().dispatch(request, *args, **kwargs)
         return HttpResponseRedirect(
             reverse("counter:details", kwargs={"counter_id": self.object.id})
             + "?bad_location"
@@ -1271,7 +1268,7 @@ class CounterLastOperationsView(CounterTabsMixin, CanViewMixin, DetailView):
 
     def get_context_data(self, **kwargs):
         """Add form to the context"""
-        kwargs = super(CounterLastOperationsView, self).get_context_data(**kwargs)
+        kwargs = super().get_context_data(**kwargs)
         threshold = timezone.now() - timedelta(
             minutes=settings.SITH_LAST_OPERATIONS_LIMIT
         )
@@ -1307,9 +1304,7 @@ class CounterCashSummaryView(CounterTabsMixin, CanViewMixin, DetailView):
                 token=request.session["counter_token"]
             ).exists()
         ):
-            return super(CounterCashSummaryView, self).dispatch(
-                request, *args, **kwargs
-            )
+            return super().dispatch(request, *args, **kwargs)
         return HttpResponseRedirect(
             reverse("counter:details", kwargs={"counter_id": self.object.id})
             + "?bad_location"
@@ -1318,7 +1313,7 @@ class CounterCashSummaryView(CounterTabsMixin, CanViewMixin, DetailView):
     def get(self, request, *args, **kwargs):
         self.object = self.get_object()
         self.form = CashRegisterSummaryForm()
-        return super(CounterCashSummaryView, self).get(request, *args, **kwargs)
+        return super().get(request, *args, **kwargs)
 
     def post(self, request, *args, **kwargs):
         self.object = self.get_object()
@@ -1326,14 +1321,14 @@ class CounterCashSummaryView(CounterTabsMixin, CanViewMixin, DetailView):
         if self.form.is_valid():
             self.form.save(self.object)
             return HttpResponseRedirect(self.get_success_url())
-        return super(CounterCashSummaryView, self).get(request, *args, **kwargs)
+        return super().get(request, *args, **kwargs)
 
     def get_success_url(self):
         return reverse_lazy("counter:details", kwargs={"counter_id": self.object.id})
 
     def get_context_data(self, **kwargs):
         """Add form to the context"""
-        kwargs = super(CounterCashSummaryView, self).get_context_data(**kwargs)
+        kwargs = super().get_context_data(**kwargs)
         kwargs["form"] = self.form
         return kwargs
 
@@ -1362,7 +1357,7 @@ class CounterStatView(DetailView, CounterAdminMixin):
         counter: Counter = self.object
         semester_start = get_start_of_semester()
         office_hours = counter.get_top_barmen()
-        kwargs = super(CounterStatView, self).get_context_data(**kwargs)
+        kwargs = super().get_context_data(**kwargs)
         kwargs.update(
             {
                 "counter": counter,
@@ -1379,7 +1374,7 @@ class CounterStatView(DetailView, CounterAdminMixin):
 
     def dispatch(self, request, *args, **kwargs):
         try:
-            return super(CounterStatView, self).dispatch(request, *args, **kwargs)
+            return super().dispatch(request, *args, **kwargs)
         except PermissionDenied:
             if (
                 request.user.is_root
@@ -1416,7 +1411,7 @@ class CashSummaryListView(CounterAdminTabsMixin, CounterAdminMixin, ListView):
 
     def get_context_data(self, **kwargs):
         """Add sums to the context"""
-        kwargs = super(CashSummaryListView, self).get_context_data(**kwargs)
+        kwargs = super().get_context_data(**kwargs)
         form = CashSummaryFormBase(self.request.GET)
         kwargs["form"] = form
         kwargs["summaries_sums"] = {}
@@ -1467,7 +1462,7 @@ class InvoiceCallView(CounterAdminTabsMixin, CounterAdminMixin, TemplateView):
 
     def get_context_data(self, **kwargs):
         """Add sums to the context"""
-        kwargs = super(InvoiceCallView, self).get_context_data(**kwargs)
+        kwargs = super().get_context_data(**kwargs)
         kwargs["months"] = Selling.objects.datetimes("date", "month", order="DESC")
         start_date = None
         end_date = None
@@ -1666,10 +1661,10 @@ class CounterRefillingListView(CounterAdminTabsMixin, CounterAdminMixin, ListVie
     def dispatch(self, request, *args, **kwargs):
         self.counter = get_object_or_404(Counter, pk=kwargs["counter_id"])
         self.queryset = Refilling.objects.filter(counter__id=self.counter.id)
-        return super(CounterRefillingListView, self).dispatch(request, *args, **kwargs)
+        return super().dispatch(request, *args, **kwargs)
 
     def get_context_data(self, **kwargs):
-        kwargs = super(CounterRefillingListView, self).get_context_data(**kwargs)
+        kwargs = super().get_context_data(**kwargs)
         kwargs["counter"] = self.counter
         return kwargs
 
@@ -1686,7 +1681,7 @@ class StudentCardFormView(FormView):
         self.customer = get_object_or_404(Customer, pk=kwargs["customer_id"])
         if not StudentCard.can_create(self.customer, request.user):
             raise PermissionDenied
-        return super(StudentCardFormView, self).dispatch(request, *args, **kwargs)
+        return super().dispatch(request, *args, **kwargs)
 
     def form_valid(self, form):
         data = form.clean()