klmp200/Sith
1
0
Fork 0
mirror of https://github.com/ae-utbm/sith.git synced 2026-02-08 08:31:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

apply ruff rule PLW0108

Browse Source
This commit is contained in:
imperosol
2026-02-03 21:11:27 +01:00
parent 4e4b5a39f7
commit bdcb802da8
2 changed files with 13 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
core/tests/test_files.py
View File

@@ -118,9 +118,9 @@ class TestFileModerationView:
(lambda: None, 403), # Anonymous user (lambda: None, 403), # Anonymous user
(lambda: baker.make(User, is_superuser=True), 200), (lambda: baker.make(User, is_superuser=True), 200),
(lambda: baker.make(User), 403), (lambda: baker.make(User), 403),
(lambda: subscriber_user.make(), 403), (subscriber_user.make, 403),
(lambda: old_subscriber_user.make(), 403), (old_subscriber_user.make, 403),
(lambda: board_user.make(), 403), (board_user.make, 403),
], ],
) )
def test_view_access( def test_view_access(
@@ -262,7 +262,7 @@ def test_apply_rights_recursively():
@pytest.mark.django_db @pytest.mark.django_db
@pytest.mark.parametrize( @pytest.mark.parametrize(
("user_receipe", "file", "expected_status"), ("user_recipe", "file", "expected_status"),
[ [
( (
lambda: None, lambda: None,
@@ -279,21 +279,21 @@ def test_apply_rights_recursively():
403, 403,
), ),
( (
lambda: subscriber_user.make(), subscriber_user.make,
SimpleUploadedFile( SimpleUploadedFile(
"test.jpg", content=RED_PIXEL_PNG, content_type="image/jpg" "test.jpg", content=RED_PIXEL_PNG, content_type="image/jpg"
), ),
200, 200,
), ),
( (
lambda: old_subscriber_user.make(), old_subscriber_user.make,
SimpleUploadedFile( SimpleUploadedFile(
"test.jpg", content=RED_PIXEL_PNG, content_type="image/jpg" "test.jpg", content=RED_PIXEL_PNG, content_type="image/jpg"
), ),
200, 200,
), ),
( (
lambda: old_subscriber_user.make(), old_subscriber_user.make,
SimpleUploadedFile( SimpleUploadedFile(
"ttesttesttesttesttesttesttesttesttesttesttesttesttesttesttestesttesttesttesttesttesttesttesttesttesttesttest.jpg", "ttesttesttesttesttesttesttesttesttesttesttesttesttesttesttestesttesttesttesttesttesttesttesttesttesttesttest.jpg",
content=RED_PIXEL_PNG, content=RED_PIXEL_PNG,
@@ -302,21 +302,21 @@ def test_apply_rights_recursively():
200, 200,
), # very long file name ), # very long file name
( (
lambda: old_subscriber_user.make(), old_subscriber_user.make,
SimpleUploadedFile( SimpleUploadedFile(
"test.jpg", content=b"invalid", content_type="image/jpg" "test.jpg", content=b"invalid", content_type="image/jpg"
), ),
422, 422,
), ),
( (
lambda: old_subscriber_user.make(), old_subscriber_user.make,
SimpleUploadedFile( SimpleUploadedFile(
"test.jpg", content=RED_PIXEL_PNG, content_type="invalid" "test.jpg", content=RED_PIXEL_PNG, content_type="invalid"
), ),
200, # PIL can guess 200, # PIL can guess
), ),
( (
lambda: old_subscriber_user.make(), old_subscriber_user.make,
SimpleUploadedFile("test.jpg", content=b"invalid", content_type="invalid"), SimpleUploadedFile("test.jpg", content=b"invalid", content_type="invalid"),
422, 422,
), ),
@@ -324,11 +324,11 @@ def test_apply_rights_recursively():
) )
def test_quick_upload_image( def test_quick_upload_image(
client: Client, client: Client,
user_receipe: Callable[[], User | None], user_recipe: Callable[[], User | None],
file: UploadedFile | None, file: UploadedFile | None,
expected_status: int, expected_status: int,
): ):
if (user := user_receipe()) is not None: if (user := user_recipe()) is not None:
client.force_login(user) client.force_login(user)
resp = client.post( resp = client.post(
reverse("api:quick_upload_image"), {"file": file} if file is not None else {} reverse("api:quick_upload_image"), {"file": file} if file is not None else {}

4
core/tests/test_user.py
View File

@@ -418,9 +418,7 @@ class TestUserQuerySetViewableBy:
viewable = User.objects.filter(id__in=[u.id for u in users]).viewable_by(user) viewable = User.objects.filter(id__in=[u.id for u in users]).viewable_by(user)
assert set(viewable) == {users[0], users[1]} assert set(viewable) == {users[0], users[1]}
@pytest.mark.parametrize( @pytest.mark.parametrize("user_factory", [lambda: baker.make(User), AnonymousUser])
"user_factory", [lambda: baker.make(User), lambda: AnonymousUser()]
)
def test_not_subscriber(self, users: list[User], user_factory): def test_not_subscriber(self, users: list[User], user_factory):
user = user_factory() user = user_factory()
viewable = User.objects.filter(id__in=[u.id for u in users]).viewable_by(user) viewable = User.objects.filter(id__in=[u.id for u in users]).viewable_by(user)