klmp200/Sith
1
0
Fork 0
mirror of https://github.com/ae-utbm/sith.git synced 2024-11-29 20:44:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

optimize User.is_subscribed and User.was_subscribed

Browse Source
This commit is contained in:
imperosol 2024-11-20 17:25:39 +01:00
parent ae7c02a583
commit a9d831e8d0
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
core/models.py
View File

@ -387,14 +387,21 @@ class User(AbstractUser):
@cached_property @cached_property
def was_subscribed(self) -> bool: def was_subscribed(self) -> bool:
if "is_subscribed" in self.__dict__ and self.is_subscribed:
# if the user is currently subscribed, he is an old subscriber too
# if the property has already been cached, avoid another request
return True
return self.subscriptions.exists() return self.subscriptions.exists()
@cached_property @cached_property
def is_subscribed(self) -> bool: def is_subscribed(self) -> bool:
s = self.subscriptions.filter( if "was_subscribed" in self.__dict__ and not self.was_subscribed:
# if the user never subscribed, he cannot be a subscriber now.
# if the property has already been cached, avoid another request
return False
return self.subscriptions.filter(
subscription_start__lte=timezone.now(), subscription_end__gte=timezone.now() subscription_start__lte=timezone.now(), subscription_end__gte=timezone.now()
) ).exists()
return s.exists()
@cached_property @cached_property
def account_balance(self): def account_balance(self):