Fix readability and avoid instantiating too many TypeAdapter

core/views/widgets/select.py

@@ -1,5 +1,8 @@
+from collections.abc import Collection
+from typing import Any
+
 from django.contrib.staticfiles.storage import staticfiles_storage
-from django.db.models import Model
+from django.db.models import Model, QuerySet
 from django.forms import Select, SelectMultiple
 from ninja import ModelSchema
 from pydantic import TypeAdapter
@@ -11,8 +14,8 @@ from core.schemas import GroupSchema, SithFileSchema, UserProfileSchema
 class AutoCompleteSelectMixin:
     component_name = "autocomplete-select"
     template_name = "core/widgets/autocomplete_select.jinja"
-    model: Model | None = None
-    schema: ModelSchema | None = None
+    model: type[Model] | None = None
+    adapter: TypeAdapter[Collection[ModelSchema]] | None = None
     pk = "id"
 
     js = [
@@ -23,6 +26,17 @@ class AutoCompleteSelectMixin:
         "core/components/ajax-select.scss",
     ]
 
+    def get_queryset(self, pks: Collection[Any]) -> QuerySet:
+        return self.model.objects.filter(
+            **{
+                f"{self.pk}__in": [
+                    pk
+                    for pk in pks
+                    if str(pk).isdigit()  # We filter empty values for create views
+                ]
+            }
+        ).all()
+
     def __init__(self, attrs=None, choices=()):
         if self.is_ajax:
             choices = ()  # Avoid computing anything when in ajax mode
@@ -30,7 +44,7 @@ class AutoCompleteSelectMixin:
 
     @property
     def is_ajax(self):
-        return self.model and self.schema
+        return self.adapter and self.model
 
     def optgroups(self, name, value, attrs=None):
         """Don't create option groups when doing ajax"""
@@ -47,20 +61,9 @@ class AutoCompleteSelectMixin:
             "css": [staticfiles_storage.url(file) for file in self.css],
         }
         if self.is_ajax:
-            adapter = TypeAdapter(list[self.schema])
-            context["initial"] = adapter.dump_json(
-                adapter.validate_python(
-                    self.model.objects.filter(
-                        **{
-                            f"{self.pk}__in": [
-                                pk
-                                for pk in context["widget"]["value"]
-                                if str(
-                                    pk
-                                ).isdigit()  # We filter empty values for create views
-                            ]
-                        }
-                    ).all()
+            context["initial"] = self.adapter.dump_json(
+                self.adapter.validate_python(
+                    self.get_queryset(context["widget"]["value"])
                 )
             ).decode("utf-8")
         return context
@@ -75,34 +78,34 @@ class AutoCompleteSelectMultiple(AutoCompleteSelectMixin, SelectMultiple): ...
 class AutoCompleteSelectUser(AutoCompleteSelect):
     component_name = "user-ajax-select"
     model = User
-    schema = UserProfileSchema
+    adapter = TypeAdapter(list[UserProfileSchema])
 
 
 class AutoCompleteSelectMultipleUser(AutoCompleteSelectMultiple):
     component_name = "user-ajax-select"
     model = User
-    schema = UserProfileSchema
+    adapter = TypeAdapter(list[UserProfileSchema])
 
 
 class AutoCompleteSelectGroup(AutoCompleteSelect):
     component_name = "group-ajax-select"
     model = Group
-    schema = GroupSchema
+    adapter = TypeAdapter(list[GroupSchema])
 
 
 class AutoCompleteSelectMultipleGroup(AutoCompleteSelectMultiple):
     component_name = "group-ajax-select"
     model = Group
-    schema = GroupSchema
+    adapter = TypeAdapter(list[GroupSchema])
 
 
 class AutoCompleteSelectSithFile(AutoCompleteSelect):
     component_name = "sith-file-ajax-select"
     model = SithFile
-    schema = SithFileSchema
+    adapter = TypeAdapter(list[SithFileSchema])
 
 
 class AutoCompleteSelectMultipleSithFile(AutoCompleteSelectMultiple):
     component_name = "sith-file-ajax-select"
     model = SithFile
-    schema = SithFileSchema
+    adapter = TypeAdapter(list[SithFileSchema])