klmp200/Sith
1
0
Fork 0
mirror of https://github.com/ae-utbm/sith3.git synced 2024-09-19 17:38:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use X-Accel-Redirect to send files in prod

Browse Source
This commit is contained in:
thomas girod 2024-08-05 00:36:29 +02:00
parent a9f66e2cd9
commit a5e4db99fb
1 changed files with 18 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
core/views/files.py
View File

@ -12,6 +12,7 @@
# OR WITHIN THE LOCAL FILE "LICENSE" # OR WITHIN THE LOCAL FILE "LICENSE"
# #
# #
from urllib.parse import quote
# This file contains all the views that concern the page model # This file contains all the views that concern the page model
from wsgiref.util import FileWrapper from wsgiref.util import FileWrapper
@ -45,10 +46,13 @@ def send_file(
file_id: int, file_id: int,
file_class: type[SithFile] = SithFile, file_class: type[SithFile] = SithFile,
file_attr: str = "file", file_attr: str = "file",
): ) -> HttpResponse:
"""Send a file through Django without loading the whole file into """Send a protected file, if the user can see it.
memory at once. The FileWrapper will turn the file object into an
iterator for chunks of 8KB. In prod, the server won't handle the download itself,
but set the appropriate headers in the response to make the reverse-proxy
deal with it.
In debug mode, the server will directly send the file.
""" """
f = get_object_or_404(file_class, id=file_id) f = get_object_or_404(file_class, id=file_id)
if not can_view(f, request.user) and not sent_from_logged_counter(request): if not can_view(f, request.user) and not sent_from_logged_counter(request):
@ -60,6 +64,16 @@ def send_file(
if not filepath.exists(): if not filepath.exists():
raise Http404 raise Http404
if not settings.DEBUG:
# When receiving a response with the Accel-Redirect header,
# the reverse proxy will automatically handle the file sending.
# This is really hard to test (thus isn't tested)
# so please do not mess with this.
response = HttpResponse(status=200)
response["Content-Type"] = ""
response["X-Accel-Redirect"] = f"/data/{quote(name)}"
return response
with open(filepath, "rb") as filename: with open(filepath, "rb") as filename:
wrapper = FileWrapper(filename) wrapper = FileWrapper(filename)
response = HttpResponse(wrapper, content_type=f.mime_type) response = HttpResponse(wrapper, content_type=f.mime_type)