klmp200/Sith
1
0
Fork 0
mirror of https://github.com/ae-utbm/sith.git synced 2026-03-31 15:59:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: reorder conditions in ClubAddMemberForm.available_roles

Browse Source
This commit is contained in:
imperosol
2026-03-31 17:08:13 +02:00
parent 11779231e1
commit 9bacf2c23d
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
club/forms.py
View File

@@ -250,19 +250,20 @@ class ClubAddMemberForm(ClubMemberForm):
widgets = {"user": AutoCompleteSelectUser} widgets = {"user": AutoCompleteSelectUser}
@cached_property @cached_property
def available_roles(self): def available_roles(self) -> QuerySet[ClubRole]:
"""The greatest role that will be obtainable with this form. """The roles that will be obtainable with this form.
Admins and the club president can attribute any role. Admins and the club president can attribute any role.
Board members can attribute roles lower than their own. Board members can attribute roles lower than their own.
Other users cannot attribute roles with this form Other users cannot attribute roles with this form
""" """
if self.request_user.has_perm("club.add_membership"):
return self.club.roles.all()
membership = self.request_user_membership membership = self.request_user_membership
if membership is None or not membership.role.is_board: if membership is None or not membership.role.is_board:
return ClubRole.objects.none() return ClubRole.objects.none()
if membership.role.is_presidency: if (
self.request_user.has_perm("club.add_membership")
or membership.role.is_presidency
):
return self.club.roles.all() return self.club.roles.all()
return self.club.roles.above_instance(membership.role) return self.club.roles.above_instance(membership.role)