klmp200/Sith
1
0
Fork 0
mirror of https://github.com/ae-utbm/sith.git synced 2024-11-22 06:03:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

club: fix mailing list form that unexpectedly relied on try catch in permissions

Browse Source
This commit is contained in:
Antoine Bartuccio 2019-10-16 21:21:06 +02:00
parent fe9164bfef
commit 811809895e
Signed by: klmp200
GPG Key ID: E7245548C53F904B
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
club/tests.py
View File

@ -641,7 +641,7 @@ class MailingFormTest(TestCase):
{"action": MailingForm.ACTION_NEW_MAILING, "mailing_email": "mde"}, {"action": MailingForm.ACTION_NEW_MAILING, "mailing_email": "mde"},
) )
mde = Mailing.objects.get(email="mde") mde = Mailing.objects.get(email="mde")
response = self.client.post( self.client.post(
reverse("club:mailing", kwargs={"club_id": self.bdf.id}), reverse("club:mailing", kwargs={"club_id": self.bdf.id}),
{ {
"action": MailingForm.ACTION_NEW_SUBSCRIPTION, "action": MailingForm.ACTION_NEW_SUBSCRIPTION,
@ -650,6 +650,11 @@ class MailingFormTest(TestCase):
"subscription_mailing": mde.id, "subscription_mailing": mde.id,
}, },
) )
response = self.client.get(
reverse("club:mailing", kwargs={"club_id": self.bdf.id})
)
self.assertContains(response, "comunity@git.an") self.assertContains(response, "comunity@git.an")
self.assertContains(response, "richard@git.an") self.assertContains(response, "richard@git.an")
self.assertContains(response, "krophil@git.an") self.assertContains(response, "krophil@git.an")

3
club/views.py
View File

@ -574,7 +574,8 @@ class ClubMailingView(ClubTabsMixin, CanEditMixin, DetailFormView):
except ValidationError as validation_error: except ValidationError as validation_error:
return validation_error return validation_error
users_to_save.append(sub.save()) sub.save()
users_to_save.append(sub)
if cleaned_data["subscription_email"]: if cleaned_data["subscription_email"]:
sub = MailingSubscription( sub = MailingSubscription(