Small fix (le gaulois)

This commit is contained in:
Skia
2016-03-24 11:55:39 +01:00
parent c3fb581f97
commit 7d7652e319
4 changed files with 15 additions and 3 deletions

View File

@ -8,7 +8,7 @@ from django.core.exceptions import ValidationError
from core.views import CanViewMixin, CanEditMixin, CanEditPropMixin
from club.models import Club, Membership
from sith.settings import AE_GROUPS
from sith.settings import AE_GROUPS, MAXIMUM_FREE_ROLE
class ClubListView(CanViewMixin, ListView):
"""
@ -42,7 +42,10 @@ class ClubMemberForm(forms.ModelForm):
"""
ret = super(ClubMemberForm, self).clean()
ms = self.instance.club.get_membership_for(self._user)
if (ms is not None and ms.role >= self.cleaned_data['role']) or self._user.is_in_group(AE_GROUPS['board']['name']) or self._user.is_superuser:
if (self.cleaned_data['role'] <= MAXIMUM_FREE_ROLE or
(ms is not None and ms.role >= self.cleaned_data['role']) or
self._user.is_in_group(AE_GROUPS['board']['name']) or
self._user.is_superuser):
return ret
raise ValidationError("You do not have the permission to do that")