write tests

counter/tests/test_auto_actions.py

@@ -0,0 +1,161 @@
+import json
+from datetime import timedelta
+
+import pytest
+from django.conf import settings
+from django.test import Client
+from django.urls import reverse
+from django.utils.timezone import now
+from django_celery_beat.models import ClockedSchedule
+from model_bakery import baker
+from pytest_django.asserts import assertNumQueries
+
+from core.models import Group, User
+from counter.baker_recipes import counter_recipe, product_recipe
+from counter.forms import ScheduledProductActionForm, ScheduledProductActionFormSet
+from counter.models import ScheduledProductAction
+
+
+@pytest.mark.django_db
+def test_edit_product(client: Client):
+    client.force_login(
+        baker.make(
+            User, groups=[Group.objects.get(id=settings.SITH_GROUP_COUNTER_ADMIN_ID)]
+        )
+    )
+    product = product_recipe.make()
+    url = reverse("counter:product_edit", kwargs={"product_id": product.id})
+    res = client.get(url)
+    assert res.status_code == 200
+
+    res = client.post(url, data={})
+    # This is actually a failure, but we just want to check that
+    # we don't have a 403 or a 500.
+    # The actual behaviour will be tested directly on the form.
+    assert res.status_code == 200
+
+
+@pytest.mark.django_db
+class TestProductActionForm:
+    def test_single_form_archive(self):
+        product = product_recipe.make()
+        trigger_at = now() + timedelta(minutes=10)
+        form = ScheduledProductActionForm(
+            product=product,
+            data={
+                "scheduled-task": "counter.tasks.archive_product",
+                "scheduled-trigger_at": trigger_at,
+            },
+        )
+        assert form.is_valid()
+        instance = form.save()
+        assert instance.clocked.clocked_time == trigger_at
+        assert instance.enabled is True
+        assert instance.one_off is True
+        assert instance.task == "counter.tasks.archive_product"
+        assert instance.kwargs == json.dumps({"product_id": product.id})
+
+    def test_single_form_change_counters(self):
+        product = product_recipe.make()
+        counter = counter_recipe.make()
+        trigger_at = now() + timedelta(minutes=10)
+        form = ScheduledProductActionForm(
+            product=product,
+            data={
+                "scheduled-task": "counter.tasks.change_counters",
+                "scheduled-trigger_at": trigger_at,
+                "scheduled-counters": [counter.id],
+            },
+        )
+        assert form.is_valid()
+        instance = form.save()
+        instance.refresh_from_db()
+        assert instance.clocked.clocked_time == trigger_at
+        assert instance.enabled is True
+        assert instance.one_off is True
+        assert instance.task == "counter.tasks.change_counters"
+        assert instance.kwargs == json.dumps(
+            {"product_id": product.id, "counters": [counter.id]}
+        )
+
+    def test_task_reused_when_editing(self):
+        """Check that when product tasks are edited, no new entry is created in db"""
+        product = product_recipe.make()
+        old_clocked = now() + timedelta(minutes=10)
+        old_instance = baker.make(
+            ScheduledProductAction,
+            product=product,
+            clocked=baker.make(ClockedSchedule, clocked_time=old_clocked),
+            task="counter.tasks.archive_product",
+        )
+        new_clocked = old_clocked + timedelta(minutes=2)
+        form = ScheduledProductActionForm(
+            product=product,
+            data={
+                "scheduled-task": "counter.tasks.archive_product",
+                "scheduled-trigger_at": new_clocked,
+            },
+        )
+        assert form.is_valid()
+        new_instance = form.save()
+        assert new_instance.id == old_instance.id
+        assert new_instance.clocked.id == old_instance.clocked.id
+        assert new_instance.clocked.clocked_time == new_clocked
+
+    def test_no_changed_data(self):
+        """Test that when no data changes, the save method does no db query"""
+        product = product_recipe.make()
+        trigger_at = now() + timedelta(minutes=2)
+        baker.make(
+            ScheduledProductAction,
+            product=product,
+            clocked=baker.make(ClockedSchedule, clocked_time=trigger_at),
+            task="counter.tasks.archive_product",
+        )
+        form = ScheduledProductActionForm(product=product, data={})
+        with assertNumQueries(0):
+            form.is_valid()
+            form.save()
+
+    def test_delete(self):
+        product = product_recipe.make()
+        trigger_at = now() + timedelta(minutes=2)
+        task = baker.make(
+            ScheduledProductAction,
+            product=product,
+            clocked=baker.make(ClockedSchedule, clocked_time=trigger_at),
+            task="counter.tasks.archive_product",
+        )
+        form = ScheduledProductActionForm(
+            product=product,
+            data={
+                "scheduled-task": "counter.tasks.archive_product",
+                "scheduled-trigger_at": trigger_at,
+            },
+        )
+        assert form.is_valid()
+        form.delete()
+        assert not ScheduledProductAction.objects.filter(id=task.id).exists()
+
+
+@pytest.mark.django_db
+class TestProductActionFormSet:
+    def test_ok(self):
+        product = product_recipe.make()
+        counter = counter_recipe.make()
+        trigger_at = now() + timedelta(minutes=10)
+        formset = ScheduledProductActionFormSet(
+            product=product,
+            data={
+                "form-TOTAL_FORMS": "2",
+                "form-INITIAL_FORMS": "0",
+                "form-0-task": "counter.tasks.archive_product",
+                "form-0-trigger_at": trigger_at,
+                "form-1-task": "counter.tasks.change_counters",
+                "form-1-trigger_at": trigger_at,
+                "form-1-counters": [counter.id],
+            },
+        )
+        assert formset.is_valid()
+        formset.save()
+        assert ScheduledProductAction.objects.filter(product=product).count() == 2