Make file modale chooser and complete user profile

core/views/__init__.py

@@ -8,8 +8,11 @@ from django.contrib.auth.forms import AuthenticationForm
 from core.models import Group
 
 def forbidden(request):
-    return HttpResponseForbidden(render(request, "core/403.jinja", context={'next': request.path, 'form':
-        AuthenticationForm(), 'popup': request.resolver_match.kwargs['popup'] or ""}))
+    try:
+        return HttpResponseForbidden(render(request, "core/403.jinja", context={'next': request.path, 'form':
+            AuthenticationForm(), 'popup': request.resolver_match.kwargs['popup'] or ""}))
+    except:
+        return HttpResponseForbidden(render(request, "core/403.jinja", context={'next': request.path, 'form': AuthenticationForm()}))
 
 def not_found(request):
     return HttpResponseNotFound(render(request, "core/404.jinja"))

core/views/files.py

@@ -37,7 +37,7 @@ def send_file(request, file_id):
         response['Content-Disposition'] = 'inline; filename="%s"' % f.name
         return response
 
-class AddFileForm(forms.Form):
+class AddFilesForm(forms.Form):
     folder_name = forms.CharField(label=_("Add a new folder"), max_length=30, required=False)
     file_field = forms.FileField(widget=forms.ClearableFileInput(attrs={'multiple': True}), label=_("Files"),
             required=False)
@@ -128,7 +128,7 @@ class FileView(CanViewMixin, DetailView, FormMixin):
     pk_url_kwarg = "file_id"
     template_name = 'core/file_detail.jinja'
     context_object_name = "file"
-    form_class = AddFileForm
+    form_class = AddFilesForm
 
     def get(self, request, *args, **kwargs):
         self.form = self.get_form()

core/views/forms.py

@@ -1,11 +1,56 @@
 from django.contrib.auth.forms import UserCreationForm, AuthenticationForm, UserChangeForm
 from django import forms
+from django.db import transaction
+from django.core.exceptions import ValidationError
 from django.contrib.auth import logout, login, authenticate
-from django.forms import CheckboxSelectMultiple, Select
+from django.forms import CheckboxSelectMultiple, Select, DateInput, TextInput
 from django.utils.translation import ugettext as _
 import logging
 
-from core.models import User, Page, RealGroup
+from core.models import User, Page, RealGroup, SithFile
+
+# Widgets
+
+class SelectSingle(Select):
+    def render(self, name, value, attrs=None):
+        if attrs:
+            attrs['class'] = "select_single"
+        else:
+            attrs = {'class': "select_single"}
+        return super(SelectSingle, self).render(name, value, attrs)
+
+class SelectMultiple(Select):
+    def render(self, name, value, attrs=None):
+        if attrs:
+            attrs['class'] = "select_multiple"
+        else:
+            attrs = {'class': "select_multiple"}
+        return super(SelectMultiple, self).render(name, value, attrs)
+
+class SelectDate(DateInput):
+    def render(self, name, value, attrs=None):
+        if attrs:
+            attrs['class'] = "select_date"
+        else:
+            attrs = {'class': "select_date"}
+        return super(SelectDate, self).render(name, value, attrs)
+
+class SelectFile(TextInput):
+    def render(self, name, value, attrs=None):
+        if attrs:
+            attrs['class'] = "select_file"
+        else:
+            attrs = {'class': "select_file"}
+        output = '%(content)s<div name="%(name)s" class="choose_file_widget" title="%(title)s"></div>' % {
+                'content': super(SelectFile, self).render(name, value, attrs),
+                'title': _("Choose file"),
+                'name': name,
+                }
+        output += '<span name="' + name + '" class="choose_file_button">' + _("Choose file") + '</span>'
+        print(output)
+        return output
+
+# Forms
 
 class RegisteringForm(UserCreationForm):
     error_css_class = 'error'
@@ -22,6 +67,69 @@ class RegisteringForm(UserCreationForm):
             user.save()
         return user
 
+class UserProfileForm(forms.ModelForm):
+    """
+    Form handling the user profile, managing the files
+    This form is actually pretty bad and was made in the rush before the migration. It should be refactored.
+    TODO: refactor this form
+    """
+    class Meta:
+        model = User
+        fields = ['first_name', 'last_name', 'nick_name', 'email', 'date_of_birth', 'profile_pict', 'avatar_pict',
+                'scrub_pict', 'sex', 'tshirt_size', 'role', 'department', 'dpt_option', 'semester', 'quote', 'school',
+                'promo', 'forum_signature']
+        widgets = {
+                'date_of_birth': SelectDate,
+                'profile_pict': forms.ClearableFileInput,
+                'avatar_pict': forms.ClearableFileInput,
+                'scrub_pict': forms.ClearableFileInput,
+                }
+        labels = {
+                'profile_pict': _("Profile: you need to be visible on the picture, in order to be recognized (e.g. by the barmen)"),
+                'avatar_pict': _("Avatar: used on the forum"),
+                'scrub_pict': _("Scrub: let other know how your scrub looks like!"),
+                }
+
+    def __init__(self, *arg, **kwargs):
+        super(UserProfileForm, self).__init__(*arg, **kwargs)
+
+    def full_clean(self):
+        super(UserProfileForm, self).full_clean()
+
+    def generate_name(self, field_name, f):
+        field_name = field_name[:-4]
+        return field_name + str(self.instance.id) + "." + f.content_type.split('/')[-1]
+
+    def process(self, files):
+        avatar = self.instance.avatar_pict
+        profile = self.instance.profile_pict
+        scrub = self.instance.scrub_pict
+        self.full_clean()
+        self.cleaned_data['avatar_pict'] = avatar
+        self.cleaned_data['profile_pict'] = profile
+        self.cleaned_data['scrub_pict'] = scrub
+        parent = SithFile.objects.filter(parent=None, name="profiles").first()
+        for field,f in files:
+            with transaction.atomic():
+                new_file = SithFile(parent=parent, name=self.generate_name(field, f), file=f, owner=self.instance, is_folder=False,
+                        mime_type=f.content_type, size=f._size)
+                try:
+                    if not (f.content_type == "image/jpeg" or
+                            f.content_type == "image/png" or
+                            f.content_type == "image/gif"):
+                        raise ValidationError(_("Bad image format, only jpeg, png, and gif are accepted"))
+                    old = SithFile.objects.filter(parent=parent, name=new_file.name).first()
+                    if old:
+                        old.delete()
+                    new_file.clean()
+                    new_file.save()
+                    self.cleaned_data[field] = new_file
+                    self._errors.pop(field, None)
+                except ValidationError as e:
+                    self._errors.pop(field, None)
+                    self.add_error(field, _("Error uploading file %(file_name)s: %(msg)s") %
+                            {'file_name': f, 'msg': str(e.message)})
+        self._post_clean()
 
 class UserPropForm(forms.ModelForm):
     error_css_class = 'error'
@@ -52,13 +160,3 @@ class PagePropForm(forms.ModelForm):
         self.fields['edit_groups'].required = False
         self.fields['view_groups'].required = False
 
-class SelectFile(Select):
-    def render(self, name, value, attrs=None):
-        output = '<span class="choose_file_widget" title="%(title)s">%(content)s</span>' % {
-                'title': _("Choose file"),
-                'content': super(SelectFile, self).render(name, value, attrs),
-                }
-        output += '<span class="choose_file_button">' + _("Choose file") + '</span>'
-        print(output)
-        return output
-

core/views/user.py

@@ -11,7 +11,7 @@ from django.conf import settings
 import logging
 
 from core.views import CanViewMixin, CanEditMixin, CanEditPropMixin
-from core.views.forms import RegisteringForm, UserPropForm
+from core.views.forms import RegisteringForm, UserPropForm, UserProfileForm
 from core.models import User
 
 def login(request):
@@ -115,7 +115,31 @@ class UserUpdateProfileView(CanEditMixin, UpdateView):
     model = User
     pk_url_kwarg = "user_id"
     template_name = "core/user_edit.jinja"
-    fields = ('first_name', 'last_name', 'nick_name', 'email', 'date_of_birth', )
+    form_class = UserProfileForm
+
+    def get(self, request, *args, **kwargs):
+        self.object = self.get_object()
+        self.form = self.get_form()
+        if self.form.instance.profile_pict and not request.user.is_in_group(settings.SITH_MAIN_BOARD_GROUP):
+            self.form.fields.pop('profile_pict', None)
+        return self.render_to_response(self.get_context_data(form=self.form))
+
+    def post(self, request, *args, **kwargs):
+        self.object = self.get_object()
+        self.form = self.get_form()
+        if self.form.instance.profile_pict and not request.user.is_in_group(settings.SITH_MAIN_BOARD_GROUP):
+            self.form.fields.pop('profile_pict', None)
+        files = request.FILES.items()
+        self.form.process(files)
+        if request.user.is_authenticated() and request.user.can_edit(self.object) and self.form.is_valid():
+            return super(UserUpdateProfileView, self).form_valid(self.form)
+        return self.form_invalid(self.form)
+
+    def get_context_data(self, **kwargs):
+        kwargs = super(UserUpdateProfileView, self).get_context_data(**kwargs)
+        kwargs['profile'] = self.form.instance
+        kwargs['form'] = self.form
+        return kwargs
 
 class UserUpdateGroupView(CanEditPropMixin, UpdateView):
     """