reorganize imports with ruff

counter/app.py

@@ -31,4 +31,4 @@ class CounterConfig(AppConfig):
     verbose_name = _("counter")
 
     def ready(self):
-        import counter.signals
+        import counter.signals  # noqa F401

counter/forms.py

@@ -3,15 +3,15 @@ from ajax_select.fields import AutoCompleteSelectField, AutoCompleteSelectMultip
 from django import forms
 from django.utils.translation import gettext_lazy as _
 
-from core.views.forms import TzAwareDateTimeField, SelectDate
+from core.views.forms import SelectDate, TzAwareDateTimeField
 from counter.models import (
     BillingInfo,
-    StudentCard,
-    Customer,
-    Refilling,
     Counter,
-    Product,
+    Customer,
     Eticket,
+    Product,
+    Refilling,
+    StudentCard,
 )
 
 

counter/migrations/0001_initial.py

@@ -1,11 +1,11 @@
 # -*- coding: utf-8 -*-
 from __future__ import unicode_literals
 
-from django.db import migrations, models
-import accounting.models
 import django.db.models.deletion
 from django.conf import settings
-import django.db.models.deletion
+from django.db import migrations, models
+
+import accounting.models
 
 
 class Migration(migrations.Migration):

counter/migrations/0002_auto_20160826_1342.py

@@ -1,10 +1,11 @@
 # -*- coding: utf-8 -*-
 from __future__ import unicode_literals
 
-from django.db import migrations, models
-from django.conf import settings
-import accounting.models
 import django.db.models.deletion
+from django.conf import settings
+from django.db import migrations, models
+
+import accounting.models
 
 
 class Migration(migrations.Migration):

counter/migrations/0003_permanency_activity.py

@@ -1,8 +1,9 @@
 # -*- coding: utf-8 -*-
 from __future__ import unicode_literals
 
-from django.db import migrations, models
 import datetime
+
+from django.db import migrations, models
 from django.utils.timezone import utc
 
 

counter/migrations/0005_auto_20160826_2330.py

@@ -1,8 +1,8 @@
 # -*- coding: utf-8 -*-
 from __future__ import unicode_literals
 
-from django.db import migrations, models
 import django.db.models.deletion
+from django.db import migrations, models
 
 
 class Migration(migrations.Migration):

counter/migrations/0009_eticket.py

@@ -1,8 +1,8 @@
 # -*- coding: utf-8 -*-
 from __future__ import unicode_literals
 
-from django.db import migrations, models
 import django.db.models.deletion
+from django.db import migrations, models
 
 
 class Migration(migrations.Migration):

counter/migrations/0013_customer_recorded_products.py

@@ -1,12 +1,12 @@
 # -*- coding: utf-8 -*-
 from __future__ import unicode_literals
 
-from django.utils.translation import gettext_lazy as _
-from django.db import migrations, models
 from django.conf import settings
+from django.db import migrations, models
+from django.utils.translation import gettext_lazy as _
 
 from core.models import User
-from counter.models import Customer, Product, Selling, Counter
+from counter.models import Counter, Customer, Product, Selling
 
 
 def balance_ecocups(apps, schema_editor):

counter/migrations/0015_merge.py

@@ -1,7 +1,7 @@
 # -*- coding: utf-8 -*-
 from __future__ import unicode_literals
 
-from django.db import migrations, models
+from django.db import migrations
 
 
 class Migration(migrations.Migration):

counter/migrations/0017_studentcard.py

@@ -3,8 +3,8 @@
 from __future__ import unicode_literals
 
 import django.core.validators
-from django.db import migrations, models
 import django.db.models.deletion
+from django.db import migrations, models
 
 
 class Migration(migrations.Migration):

counter/migrations/0019_billinginfo.py

@@ -1,8 +1,8 @@
 # Generated by Django 3.2.16 on 2023-01-08 12:49
 
-from django.db import migrations, models
 import django.db.models.deletion
 import django_countries.fields
+from django.db import migrations, models
 
 
 class Migration(migrations.Migration):

counter/migrations/0020_auto_20221215_1709.py

@@ -1,8 +1,9 @@
 # Generated by Django 3.2.16 on 2022-12-15 16:09
 
-import accounting.models
 from django.db import migrations
 
+import accounting.models
+
 
 class Migration(migrations.Migration):
     dependencies = [

counter/models.py

@@ -15,35 +15,33 @@
 #
 from __future__ import annotations
 
-from typing import Tuple, Optional
-
-from django.db import models
-from django.db.models import F, Value, Sum, QuerySet, OuterRef, Exists
-from django.db.models.functions import Concat, Length
-from django.utils.translation import gettext_lazy as _
-from django.utils import timezone
-from django.conf import settings
-from django.urls import reverse
-from django.core.validators import MinLengthValidator
-from django.forms import ValidationError
-from django.utils.functional import cached_property
-
-from datetime import timedelta, date, datetime
+import base64
+import os
 import random
 import string
-import os
-import base64
-from dict2xml import dict2xml
+from datetime import date, datetime, timedelta
+from typing import Optional, Tuple
 
+from dict2xml import dict2xml
+from django.conf import settings
+from django.core.validators import MinLengthValidator
+from django.db import models
+from django.db.models import Exists, F, OuterRef, QuerySet, Sum, Value
+from django.db.models.functions import Concat, Length
+from django.forms import ValidationError
+from django.urls import reverse
+from django.utils import timezone
+from django.utils.functional import cached_property
+from django.utils.translation import gettext_lazy as _
+from django_countries.fields import CountryField
+
+from accounting.models import CurrencyField
+from club.models import Club
+from core.models import Group, Notification, User
 from core.utils import get_start_of_semester
 from sith.settings import SITH_COUNTER_OFFICES, SITH_MAIN_CLUB
-from club.models import Club, Membership
-from accounting.models import CurrencyField
-from core.models import Group, User, Notification
 from subscription.models import Subscription
 
-from django_countries.fields import CountryField
-
 
 class Customer(models.Model):
     """

counter/signals.py

@@ -24,12 +24,10 @@
 
 from django.db.models.signals import pre_delete
 from django.dispatch import receiver
-from django.conf import settings
 
 from core.middleware import get_signal_request
 from core.models import OperationLog
-
-from counter.models import Selling, Refilling, Counter
+from counter.models import Counter, Refilling, Selling
 
 
 def write_log(instance, operation_type):

counter/tests.py

@@ -13,20 +13,18 @@
 # OR WITHIN THE LOCAL FILE "LICENSE"
 #
 #
-from datetime import date, timedelta
 import json
 import re
 import string
 
 from django.test import TestCase
 from django.urls import reverse
-from django.core.management import call_command
 from django.utils import timezone
 from django.utils.timezone import timedelta
 
 from club.models import Club
 from core.models import User
-from counter.models import Counter, Customer, BillingInfo, Permanency, Selling, Product
+from counter.models import BillingInfo, Counter, Customer, Permanency, Product, Selling
 from sith.settings import SITH_MAIN_CLUB
 
 

counter/views.py

@@ -14,68 +14,65 @@
 #
 #
 import json
+import re
+from datetime import datetime, timedelta
+from http import HTTPStatus
 from urllib.parse import parse_qs
 
+import pytz
+from django import forms
+from django.conf import settings
 from django.contrib.auth.decorators import login_required
-from django.db.models import F
-from django.shortcuts import get_object_or_404
-from django.http import Http404
 from django.core.exceptions import PermissionDenied
+from django.db import DataError, transaction
+from django.db.models import F
+from django.forms import CheckboxSelectMultiple
+from django.forms.models import modelform_factory
+from django.http import Http404, HttpResponse, HttpResponseRedirect, JsonResponse
+from django.shortcuts import get_object_or_404
+from django.urls import reverse, reverse_lazy
+from django.utils import timezone
+from django.utils.translation import gettext_lazy as _
 from django.views.decorators.http import require_POST
-from django.views.generic import ListView, DetailView, RedirectView, TemplateView
+from django.views.generic import DetailView, ListView, RedirectView, TemplateView
 from django.views.generic.base import View
 from django.views.generic.edit import (
-    UpdateView,
     CreateView,
     DeleteView,
-    ProcessFormView,
     FormMixin,
     FormView,
+    ProcessFormView,
+    UpdateView,
 )
-from django.forms.models import modelform_factory
-from django.forms import CheckboxSelectMultiple
-from django.urls import reverse_lazy, reverse
-from django.http import HttpResponseRedirect, HttpResponse, JsonResponse
-from django.utils import timezone
-from django import forms
-from django.utils.translation import gettext_lazy as _
-from django.conf import settings
-from django.db import DataError, transaction
 
-import json
-import re
-import pytz
-from datetime import timedelta, datetime
-from http import HTTPStatus
-
-from core.utils import get_start_of_semester, get_semester_code
-from core.views import CanViewMixin, TabedViewMixin, CanEditMixin
-from core.views.forms import LoginForm
+from accounting.models import CurrencyField
 from core.models import User
+from core.utils import get_semester_code, get_start_of_semester
+from core.views import CanEditMixin, CanViewMixin, TabedViewMixin
+from core.views.forms import LoginForm
 from counter.forms import (
     BillingInfoForm,
-    StudentCardForm,
-    GetUserForm,
-    RefillForm,
-    CounterEditForm,
-    ProductEditForm,
     CashSummaryFormBase,
+    CounterEditForm,
     EticketForm,
+    GetUserForm,
+    ProductEditForm,
+    RefillForm,
+    StudentCardForm,
 )
 from counter.models import (
-    Counter,
-    Customer,
-    StudentCard,
-    Product,
-    Selling,
-    Refilling,
-    ProductType,
+    BillingInfo,
     CashRegisterSummary,
     CashRegisterSummaryItem,
+    Counter,
+    Customer,
     Eticket,
-    BillingInfo,
+    Product,
+    ProductType,
+    Refilling,
+    Selling,
+    StudentCard,
 )
-from accounting.models import CurrencyField
 
 
 class CounterAdminMixin(View):
@@ -1486,7 +1483,7 @@ class InvoiceCallView(CounterAdminTabsMixin, CounterAdminMixin, TemplateView):
         end_date = (start_date + timedelta(days=32)).replace(
             day=1, hour=0, minute=0, microsecond=0
         )
-        from django.db.models import Sum, Case, When, F
+        from django.db.models import Case, F, Sum, When
 
         kwargs["sum_cb"] = sum(
             [
@@ -1574,12 +1571,12 @@ class EticketPDFView(CanViewMixin, DetailView):
     pk_url_kwarg = "selling_id"
 
     def get(self, request, *args, **kwargs):
-        from reportlab.pdfgen import canvas
-        from reportlab.lib.utils import ImageReader
-        from reportlab.lib.units import cm
-        from reportlab.graphics.shapes import Drawing
-        from reportlab.graphics.barcode.qr import QrCodeWidget
         from reportlab.graphics import renderPDF
+        from reportlab.graphics.barcode.qr import QrCodeWidget
+        from reportlab.graphics.shapes import Drawing
+        from reportlab.lib.units import cm
+        from reportlab.lib.utils import ImageReader
+        from reportlab.pdfgen import canvas
 
         if not (
             hasattr(self.object, "product") and hasattr(self.object.product, "eticket")