ruff rule FBT

core/management/commands/install_xapian.py

@@ -46,7 +46,7 @@ class Command(BaseCommand):
             pyproject = tomli.load(f)
             return pyproject["tool"]["xapian"]["version"]
 
-    def handle(self, force: bool, *args, **options):
+    def handle(self, *args, force: bool, **options):
         if not os.environ.get("VIRTUAL_ENV", None):
             print("No virtual environment detected, this command can't be used")
             return

core/models.py

@@ -1055,13 +1055,13 @@ class SithFile(models.Model):
                     param="1",
                 ).save()
 
-    def apply_rights_recursively(self, only_folders=False):
+    def apply_rights_recursively(self, *, only_folders=False):
         children = self.children.all()
         if only_folders:
             children = children.filter(is_folder=True)
         for c in children:
             c.copy_rights()
-            c.apply_rights_recursively(only_folders)
+            c.apply_rights_recursively(only_folders=only_folders)
 
     def copy_rights(self):
         """Copy, if possible, the rights of the parent folder"""

core/views/forms.py

@@ -194,7 +194,7 @@ class RegisteringForm(UserCreationForm):
         model = User
         fields = ("first_name", "last_name", "email")
 
-    def save(self, commit=True):
+    def save(self, *, commit=True):
         user = super().save(commit=False)
         user.set_password(self.cleaned_data["password1"])
         user.generate_username()

core/views/site.py

@@ -74,7 +74,7 @@ def notification(request, notif_id):
     return redirect("/")
 
 
-def search_user(query, as_json=False):
+def search_user(query):
     try:
         # slugify turns everything into ascii and every whitespace into -
         # it ends by removing duplicate - (so ' - ' will turn into '-')
@@ -93,7 +93,7 @@ def search_user(query, as_json=False):
         return []
 
 
-def search_club(query, as_json=False):
+def search_club(query,* , as_json=False):
     clubs = []
     if query:
         clubs = Club.objects.filter(name__icontains=query).all()
@@ -117,15 +117,15 @@ def search_view(request):
 
 @login_required
 def search_user_json(request):
-    result = {"users": search_user(request.GET.get("query", ""), True)}
+    result = {"users": search_user(request.GET.get("query", ""))}
     return JsonResponse(result)
 
 
 @login_required
 def search_json(request):
     result = {
-        "users": search_user(request.GET.get("query", ""), True),
-        "clubs": search_club(request.GET.get("query", ""), True),
+        "users": search_user(request.GET.get("query", "")),
+        "clubs": search_club(request.GET.get("query", ""), as_json=True),
     }
     return JsonResponse(result)