mirror of
https://github.com/ae-utbm/sith.git
synced 2024-11-22 06:03:20 +00:00
Hotfix: better handle atomicity in eboutic basket validation
This commit is contained in:
parent
9f4f3bf436
commit
11c263b6e7
@ -9,6 +9,7 @@ from django.shortcuts import render
|
||||
from django.core.urlresolvers import reverse_lazy
|
||||
from django.views.generic import TemplateView, View
|
||||
from django.http import HttpResponse, HttpResponseRedirect
|
||||
from django.core.exceptions import SuspiciousOperation
|
||||
from django.shortcuts import render
|
||||
from django.db import transaction, DataError
|
||||
from django.utils.translation import ugettext as _
|
||||
@ -177,10 +178,11 @@ class EtransactionAutoAnswer(View):
|
||||
except:
|
||||
return HttpResponse("Bad signature", status=400)
|
||||
if request.GET['Error'] == "00000":
|
||||
try:
|
||||
with transaction.atomic():
|
||||
b = Basket.objects.filter(id=request.GET['BasketID']).first()
|
||||
if b is None:
|
||||
return HttpResponse("Basket does not exists", status=400)
|
||||
raise SuspiciousOperation("Basket does not exists")
|
||||
i = Invoice()
|
||||
i.user = b.user
|
||||
i.payment_method = "CARD"
|
||||
@ -190,7 +192,9 @@ class EtransactionAutoAnswer(View):
|
||||
product_unit_price=it.product_unit_price, quantity=it.quantity).save()
|
||||
i.validate()
|
||||
b.delete()
|
||||
except Exception as e:
|
||||
return HttpResponse("Payment failed with error: "+repr(e), status=400)
|
||||
return HttpResponse()
|
||||
else:
|
||||
return HttpResponse("Payment failed with error: "+request.GET['Error'])
|
||||
return HttpResponse("Payment failed with error: "+request.GET['Error'], status=400)
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user