Remove defer from script where type=module is used

This commit is contained in:
Antoine Bartuccio 2024-11-19 15:16:23 +01:00 committed by Bartuccio Antoine
parent 8a8851847c
commit 0485ab1120
12 changed files with 19 additions and 14 deletions

View File

@ -1,7 +1,7 @@
{% extends "core/base.jinja" %} {% extends "core/base.jinja" %}
{% block additional_js %} {% block additional_js %}
{% if settings.SENTRY_DSN %} {% if settings.SENTRY_DSN %}
<script src="{{ static('bundled/sentry-popup-index.ts') }}" defer ></script> <script type="module" src="{{ static('bundled/sentry-popup-index.ts') }}"></script>
{% endif %} {% endif %}
{% endblock additional_js %} {% endblock additional_js %}

View File

@ -7,7 +7,7 @@
{%- endblock -%} {%- endblock -%}
{% block additional_js %} {% block additional_js %}
<script type="module" src="{{ static("bundled/user/family-graph-index.js") }}" defer></script> <script type="module" src="{{ static("bundled/user/family-graph-index.js") }}"></script>
{% endblock %} {% endblock %}
{% block title %} {% block title %}

View File

@ -5,7 +5,7 @@
{%- endblock -%} {%- endblock -%}
{% block additional_js %} {% block additional_js %}
<script type="module" src="{{ static('bundled/user/pictures-index.js') }}" defer></script> <script type="module" src="{{ static('bundled/user/pictures-index.js') }}"></script>
{% endblock %} {% endblock %}
{% block title %} {% block title %}

View File

@ -1,5 +1,5 @@
{% for js in statics.js %} {% for js in statics.js %}
<script-once type="module" src="{{ js }}" defer></script-once> <script-once type="module" src="{{ js }}"></script-once>
{% endfor %} {% endfor %}
{% for css in statics.css %} {% for css in statics.css %}
<link-once rel="stylesheet" type="text/css" href="{{ css }}" defer></link-once> <link-once rel="stylesheet" type="text/css" href="{{ css }}" defer></link-once>

View File

@ -1,5 +1,5 @@
<div> <div>
<script-once type="module" src="{{ statics.js }}" defer></script-once> <script-once type="module" src="{{ statics.js }}"></script-once>
<link-once rel="stylesheet" type="text/css" href="{{ statics.css }}" defer></link-once> <link-once rel="stylesheet" type="text/css" href="{{ statics.css }}" defer></link-once>
<markdown-input name="{{ widget.name }}"{% include "django/forms/widgets/attrs.html" %}>{% if widget.value %}{{ widget.value }}{% endif %}</markdown-input> <markdown-input name="{{ widget.name }}"{% include "django/forms/widgets/attrs.html" %}>{% if widget.value %}{{ widget.value }}{% endif %}</markdown-input>

View File

@ -1,4 +1,4 @@
<script-once type="module" src="{{ statics.js }}" defer></script-once> <script-once type="module" src="{{ statics.js }}"></script-once>
<link-once rel="stylesheet" type="text/css" href="{{ statics.css }}" defer></link-once> <link-once rel="stylesheet" type="text/css" href="{{ statics.css }}" defer></link-once>
<span> <span>

View File

@ -36,8 +36,8 @@ Pour accéder au fichier, il faut utiliser `static` comme pour le reste mais en
```jinja ```jinja
{# Example pour ajouter sith/core/bundled/alpine-index.js #} {# Example pour ajouter sith/core/bundled/alpine-index.js #}
<script src="{{ static('bundled/alpine-index.js') }}" defer></script> <script type="module" src="{{ static('bundled/alpine-index.js') }}"></script>
<script src="{{ static('bundled/other-index.ts') }}" defer></script> <script type="module" src="{{ static('bundled/other-index.ts') }}"></script>
``` ```
!!!note !!!note
@ -46,6 +46,11 @@ Pour accéder au fichier, il faut utiliser `static` comme pour le reste mais en
Les autres fichiers sont disponibles à l'import dans le JavaScript comme Les autres fichiers sont disponibles à l'import dans le JavaScript comme
si ils étaient tous au même niveau. si ils étaient tous au même niveau.
!!!warning
Le bundler ne génère que des modules javascript.
Ajouter `type="module"` n'est pas optionnel !
### Les imports au sein des fichiers des fichiers javascript bundlés ### Les imports au sein des fichiers des fichiers javascript bundlés
Pour importer au sein d'un fichier js bundlé, il faut préfixer ses imports de `#app:`. Pour importer au sein d'un fichier js bundlé, il faut préfixer ses imports de `#app:`.

View File

@ -5,7 +5,7 @@
{% endblock %} {% endblock %}
{% block additional_js %} {% block additional_js %}
<script type="module" src="{{ static('bundled/galaxy/galaxy-index.js') }}" defer></script> <script type="module" src="{{ static('bundled/galaxy/galaxy-index.js') }}"></script>
{% endblock %} {% endblock %}

View File

@ -10,7 +10,7 @@
{% endblock %} {% endblock %}
{% block additional_js %} {% block additional_js %}
<script type="module" src="{{ static('bundled/pedagogy/guide-index.js') }}" defer></script> <script type="module" src="{{ static('bundled/pedagogy/guide-index.js') }}"></script>
{% endblock %} {% endblock %}
{% block head %} {% block head %}

View File

@ -6,7 +6,7 @@
{%- endblock -%} {%- endblock -%}
{%- block additional_js -%} {%- block additional_js -%}
<script type="module" src="{{ static('bundled/sas/album-index.js') }}" defer></script> <script type="module" src="{{ static('bundled/sas/album-index.js') }}"></script>
{%- endblock -%} {%- endblock -%}
{% block title %} {% block title %}

View File

@ -7,8 +7,8 @@
{%- endblock -%} {%- endblock -%}
{%- block additional_js -%} {%- block additional_js -%}
<script type="module" defer src="{{ static('bundled/core/components/ajax-select-index.ts') }}"></script> <script type="module" src="{{ static('bundled/core/components/ajax-select-index.ts') }}"></script>
<script type="module" defer src="{{ static("bundled/sas/viewer-index.ts") }}"></script> <script type="module" src="{{ static("bundled/sas/viewer-index.ts") }}"></script>
{%- endblock -%} {%- endblock -%}
{% block title %} {% block title %}

View File

@ -6,7 +6,7 @@
{% block head %} {% block head %}
{{ super() }} {{ super() }}
<script type="module" src="{{ static('bundled/subscription/stats-index.ts') }}" defer></script> <script type="module" src="{{ static('bundled/subscription/stats-index.ts') }}"></script>
{% endblock %} {% endblock %}
{% block content %} {% block content %}