diff --git a/club/api.py b/club/api.py index fe71d7bd..cde007c2 100644 --- a/club/api.py +++ b/club/api.py @@ -9,7 +9,6 @@ from api.auth import ApiKeyAuth from api.permissions import CanView, HasPerm from club.models import Club, Membership from club.schemas import ( - ClubProfileSchema, ClubSchema, ClubSearchFilterSchema, SimpleClubSchema, @@ -29,16 +28,6 @@ class ClubController(ControllerBase): def search_club(self, filters: Query[ClubSearchFilterSchema]): return filters.filter(Club.objects.order_by("name")).values() - @route.get( - "/search-profile", - response=PaginatedResponseSchema[ClubProfileSchema], - url_name="search_club_profile", - ) - @paginate(PageNumberPaginationExtra, page_size=50) - def search_club_profile(self, filters: Query[ClubSearchFilterSchema]): - """Same as /api/club/search, but with more returned data""" - return filters.filter(Club.objects.order_by("name")) - @route.get( "/{int:club_id}", response=ClubSchema, diff --git a/club/templates/club/club_list.jinja b/club/templates/club/club_list.jinja index 7698013d..1367012b 100644 --- a/club/templates/club/club_list.jinja +++ b/club/templates/club/club_list.jinja @@ -33,7 +33,9 @@
{{ form }}
- +

{% trans %}Club list{% endtrans %}

{% if user.has_perm("club.add_club") %} diff --git a/club/tests/test_club.py b/club/tests/test_club.py index 16de4e9b..4c69b2c4 100644 --- a/club/tests/test_club.py +++ b/club/tests/test_club.py @@ -30,8 +30,12 @@ def test_club_queryset_having_board_member(): assert set(club_ids) == {clubs[1].id, clubs[2].id} +@pytest.mark.parametrize("nb_additional_clubs", [10, 30]) +@pytest.mark.parametrize("is_fragment", [True, False]) @pytest.mark.django_db -def test_club_list(client: Client): +def test_club_list(client: Client, nb_additional_clubs: int, is_fragment): client.force_login(baker.make(User)) - res = client.get(reverse("club:club_list")) + baker.make(Club, _quantity=nb_additional_clubs) + headers = {"HX-Request": True} if is_fragment else {} + res = client.get(reverse("club:club_list"), headers=headers) assert res.status_code == 200 diff --git a/club/tests/test_club_controller.py b/club/tests/test_club_controller.py index e7ecff2e..500dbe6a 100644 --- a/club/tests/test_club_controller.py +++ b/club/tests/test_club_controller.py @@ -59,14 +59,6 @@ class TestClubSearch(TestCase): ids = {d["id"] for d in response.json()["results"]} assert ids == {c.id for c in [self.clubs[0], self.clubs[1], self.clubs[3]]} - def test_club_search_profile(self): - self.client.force_login(self.user) - url = reverse("api:search_club_profile") - response = self.client.get(url, {"search": "AE"}) - assert response.status_code == 200 - ids = {d["id"] for d in response.json()["results"]} - assert ids == {c.id for c in [self.clubs[0], self.clubs[1], self.clubs[3]]} - @pytest.mark.django_db class TestFetchClub: diff --git a/club/views.py b/club/views.py index 45396a76..f9bf5a1d 100644 --- a/club/views.py +++ b/club/views.py @@ -218,7 +218,7 @@ class ClubListView(AllowFragment, FormMixin, ListView): form: ClubSearchForm = self.get_form() qs = self.queryset if not form.is_bound: - return qs + return qs.filter(is_active=True) if not form.is_valid(): return qs.none() if name := form.cleaned_data.get("name"):