From b0e24350e2b80e77ded402071c472e7650306b61 Mon Sep 17 00:00:00 2001
From: Thomas Girod <thgirod@hotmail.com>
Date: Sun, 6 Apr 2025 11:37:09 +0200
Subject: [PATCH] fix com admin pages

---
 com/tests/test_views.py | 23 +++++++++++++++++++++--
 com/views.py            | 27 +++++++++++++++------------
 2 files changed, 36 insertions(+), 14 deletions(-)

diff --git a/com/tests/test_views.py b/com/tests/test_views.py
index 03d28adc..607d4b3f 100644
--- a/com/tests/test_views.py
+++ b/com/tests/test_views.py
@@ -19,7 +19,7 @@ import pytest
 from django.conf import settings
 from django.contrib.sites.models import Site
 from django.core.files.uploadedfile import SimpleUploadedFile
-from django.test import TestCase
+from django.test import Client, TestCase
 from django.urls import reverse
 from django.utils import html
 from django.utils.timezone import localtime, now
@@ -323,7 +323,7 @@ class TestNewsCreation(TestCase):
 
 
 @pytest.mark.django_db
-def test_feed(client):
+def test_feed(client: Client):
     """Smoke test that checks that the atom feed is working"""
     Site.objects.clear_cache()
     with assertNumQueries(2):
@@ -332,3 +332,22 @@ def test_feed(client):
         resp = client.get(reverse("com:news_feed"))
         assert resp.status_code == 200
         assert resp.headers["Content-Type"] == "application/rss+xml; charset=utf-8"
+
+
+@pytest.mark.django_db
+@pytest.mark.parametrize(
+    "url",
+    [
+        reverse("com:poster_list"),
+        reverse("com:poster_create"),
+        reverse("com:poster_moderate_list"),
+    ],
+)
+def test_poster_management_views_crash_test(client: Client, url: str):
+    """Test that poster management views work"""
+    user = baker.make(
+        User, groups=[Group.objects.get(pk=settings.SITH_GROUP_COM_ADMIN_ID)]
+    )
+    client.force_login(user)
+    res = client.get(url)
+    assert res.status_code == 200
diff --git a/com/views.py b/com/views.py
index f6e12fd2..024cb781 100644
--- a/com/views.py
+++ b/com/views.py
@@ -61,8 +61,7 @@ sith = Sith.objects.first
 
 
 class ComTabsMixin(TabedViewMixin):
-    def get_tabs_title(self):
-        return _("Communication administration")
+    tabs_title = _("Communication administration")
 
     def get_list_of_tabs(self):
         return [
@@ -559,7 +558,11 @@ class MailingModerateView(View):
         raise PermissionDenied
 
 
-class PosterListBaseView(ListView):
+class PosterAdminViewMixin(IsComAdminMixin, ComTabsMixin):
+    current_tab = "posters"
+
+
+class PosterListBaseView(PosterAdminViewMixin, ListView):
     """List communication posters."""
 
     current_tab = "posters"
@@ -586,7 +589,7 @@ class PosterListBaseView(ListView):
         return kwargs
 
 
-class PosterCreateBaseView(CreateView):
+class PosterCreateBaseView(PosterAdminViewMixin, CreateView):
     """Create communication poster."""
 
     current_tab = "posters"
@@ -618,7 +621,7 @@ class PosterCreateBaseView(CreateView):
         return super().form_valid(form)
 
 
-class PosterEditBaseView(UpdateView):
+class PosterEditBaseView(PosterAdminViewMixin, UpdateView):
     """Edit communication poster."""
 
     pk_url_kwarg = "poster_id"
@@ -664,7 +667,7 @@ class PosterEditBaseView(UpdateView):
         return super().form_valid(form)
 
 
-class PosterDeleteBaseView(DeleteView):
+class PosterDeleteBaseView(PosterAdminViewMixin, DeleteView):
     """Edit communication poster."""
 
     pk_url_kwarg = "poster_id"
@@ -681,7 +684,7 @@ class PosterDeleteBaseView(DeleteView):
         return super().dispatch(request, *args, **kwargs)
 
 
-class PosterListView(IsComAdminMixin, ComTabsMixin, PosterListBaseView):
+class PosterListView(PosterListBaseView):
     """List communication posters."""
 
     def get_context_data(self, **kwargs):
@@ -690,7 +693,7 @@ class PosterListView(IsComAdminMixin, ComTabsMixin, PosterListBaseView):
         return kwargs
 
 
-class PosterCreateView(IsComAdminMixin, ComTabsMixin, PosterCreateBaseView):
+class PosterCreateView(PosterCreateBaseView):
     """Create communication poster."""
 
     success_url = reverse_lazy("com:poster_list")
@@ -701,7 +704,7 @@ class PosterCreateView(IsComAdminMixin, ComTabsMixin, PosterCreateBaseView):
         return kwargs
 
 
-class PosterEditView(IsComAdminMixin, ComTabsMixin, PosterEditBaseView):
+class PosterEditView(PosterEditBaseView):
     """Edit communication poster."""
 
     success_url = reverse_lazy("com:poster_list")
@@ -712,13 +715,13 @@ class PosterEditView(IsComAdminMixin, ComTabsMixin, PosterEditBaseView):
         return kwargs
 
 
-class PosterDeleteView(IsComAdminMixin, ComTabsMixin, PosterDeleteBaseView):
+class PosterDeleteView(PosterDeleteBaseView):
     """Delete communication poster."""
 
     success_url = reverse_lazy("com:poster_list")
 
 
-class PosterModerateListView(IsComAdminMixin, ComTabsMixin, ListView):
+class PosterModerateListView(PosterAdminViewMixin, ListView):
     """Moderate list communication poster."""
 
     current_tab = "posters"
@@ -732,7 +735,7 @@ class PosterModerateListView(IsComAdminMixin, ComTabsMixin, ListView):
         return kwargs
 
 
-class PosterModerateView(IsComAdminMixin, ComTabsMixin, View):
+class PosterModerateView(PosterAdminViewMixin, View):
     """Moderate communication poster."""
 
     def get(self, request, *args, **kwargs):