From a01ea13f5b88a889a3118ca132a84ce9bc6e12cd Mon Sep 17 00:00:00 2001
From: Sli <antoine@bartuccio.fr>
Date: Tue, 25 Feb 2025 18:07:06 +0100
Subject: [PATCH] Fix crash when no news is available

---
 com/templates/com/news_list.jinja |  4 ++--
 com/views.py                      | 40 ++++++++++++++++++-------------
 2 files changed, 26 insertions(+), 18 deletions(-)

diff --git a/com/templates/com/news_list.jinja b/com/templates/com/news_list.jinja
index af15b20e..172cc888 100644
--- a/com/templates/com/news_list.jinja
+++ b/com/templates/com/news_list.jinja
@@ -44,7 +44,7 @@
             <em>{% trans %}Nothing to come...{% endtrans %}</em>
           </div>
         {% else %}
-          {% for day, dates_group in news_dates %}
+          {% for day, dates_group in news_dates.items() %}
             <div class="news_events_group">
               <div class="news_events_group_date">
                 <div>
@@ -120,7 +120,7 @@
                   <template x-for="newsDate in newsList" :key="newsDate.id">
                     <article
                       class="news_event"
-                      x-data="{ newsState: newsDate.news.is_published ? AlertState.PULISHED : AlertState.PENDING }"
+                      x-data="{ newsState: newsDate.news.is_published ? AlertState.PUBLISHED : AlertState.PENDING }"
                     >
                       <template x-if="!newsDate.news.is_published">
                         {{ news_moderation_alert("newsDate.news.id", user, "newsState") }}
diff --git a/com/views.py b/com/views.py
index 2315cac2..77a42fd1 100644
--- a/com/views.py
+++ b/com/views.py
@@ -253,7 +253,7 @@ class NewsListView(TemplateView):
             key=lambda u: u.date_of_birth.year,
         )
 
-    def get_last_day(self) -> date:
+    def get_last_day(self) -> date | None:
         """Get the last day when news will be displayed
 
         The returned day is the third one where something happen.
@@ -261,31 +261,39 @@ class NewsListView(TemplateView):
         D on 20/03, E on 21/03 and F on 22/03 ;
         then the result is 20/03.
         """
-        return list(
-            NewsDate.objects.filter(end_date__gt=now())
-            .order_by("start_date")
-            .values_list("start_date__date", flat=True)
-            .distinct()[:4]
-        )[-1]
+        try:
+            return list(
+                NewsDate.objects.filter(end_date__gt=now())
+                .order_by("start_date")
+                .values_list("start_date__date", flat=True)
+                .distinct()[:4]
+            )[-1]
+        except IndexError:
+            return None
 
-    def get_news_dates(self, until: date):
+    def get_news_dates(self, until: date) -> dict[date, list[date]]:
         """Return the event dates to display.
 
         The selected events are the ones that happens between
         right now and the given day (included).
         """
-        return itertools.groupby(
-            NewsDate.objects.viewable_by(self.request.user)
-            .filter(end_date__gt=now(), start_date__date__lte=until)
-            .order_by("start_date")
-            .select_related("news", "news__club"),
-            key=lambda d: d.start_date.date(),
-        )
+        return {
+            date: list(dates)
+            for date, dates in itertools.groupby(
+                NewsDate.objects.viewable_by(self.request.user)
+                .filter(end_date__gt=now(), start_date__date__lte=until)
+                .order_by("start_date")
+                .select_related("news", "news__club"),
+                key=lambda d: d.start_date.date(),
+            )
+        }
 
     def get_context_data(self, **kwargs):
         last_day = self.get_last_day()
         return super().get_context_data(**kwargs) | {
-            "news_dates": self.get_news_dates(until=last_day),
+            "news_dates": self.get_news_dates(until=last_day)
+            if last_day is not None
+            else {},
             "birthdays": self.get_birthdays(),
             "last_day": last_day,
         }