From 6cc234e8d3ef9b4aba5527751a3a6d8289b23807 Mon Sep 17 00:00:00 2001 From: Bartuccio Antoine Date: Sat, 5 Oct 2019 19:09:15 +0200 Subject: [PATCH] django2.2: add default mandatory on_delete on OneToOneField --- accounting/models.py | 1 + club/models.py | 4 +++- counter/models.py | 7 +++++-- forum/models.py | 4 +++- launderette/models.py | 5 ++++- stock/models.py | 5 ++++- trombi/models.py | 7 +++++-- 7 files changed, 25 insertions(+), 8 deletions(-) diff --git a/accounting/models.py b/accounting/models.py index 73437f7c..54fcb437 100644 --- a/accounting/models.py +++ b/accounting/models.py @@ -352,6 +352,7 @@ class Operation(models.Model): null=True, blank=True, default=None, + on_delete=models.CASCADE, ) class Meta: diff --git a/club/models.py b/club/models.py index e23c99bb..f625d2e4 100644 --- a/club/models.py +++ b/club/models.py @@ -96,7 +96,9 @@ class Club(models.Model): blank=True, on_delete=models.SET_NULL, ) - page = models.OneToOneField(Page, related_name="club", blank=True, null=True) + page = models.OneToOneField( + Page, related_name="club", blank=True, null=True, on_delete=models.CASCADE + ) class Meta: ordering = ["name", "unix_name"] diff --git a/counter/models.py b/counter/models.py index 5b7f8bf4..584bb99a 100644 --- a/counter/models.py +++ b/counter/models.py @@ -51,7 +51,7 @@ class Customer(models.Model): is used by other accounting classes as reference to the customer, rather than using User """ - user = models.OneToOneField(User, primary_key=True) + user = models.OneToOneField(User, primary_key=True, on_delete=models.CASCADE) account_id = models.CharField(_("account id"), max_length=10, unique=True) amount = CurrencyField(_("amount")) recorded_products = models.IntegerField(_("recorded product"), default=0) @@ -727,7 +727,10 @@ class Eticket(models.Model): """ product = models.OneToOneField( - Product, related_name="eticket", verbose_name=_("product") + Product, + related_name="eticket", + verbose_name=_("product"), + on_delete=models.CASCADE, ) banner = models.ImageField( upload_to="etickets", null=True, blank=True, verbose_name=_("banner") diff --git a/forum/models.py b/forum/models.py index 6967a4c2..41785640 100644 --- a/forum/models.py +++ b/forum/models.py @@ -421,7 +421,9 @@ class ForumUserInfo(models.Model): user, such as the favourite topics, the signature, and so on... """ - user = models.OneToOneField(User, related_name="_forum_infos") + user = models.OneToOneField( + User, related_name="_forum_infos", on_delete=models.CASCADE + ) last_read_date = models.DateTimeField( _("last read date"), default=datetime( diff --git a/launderette/models.py b/launderette/models.py index 8c78bd4c..14cd4f77 100644 --- a/launderette/models.py +++ b/launderette/models.py @@ -37,7 +37,10 @@ from club.models import Club class Launderette(models.Model): name = models.CharField(_("name"), max_length=30) counter = models.OneToOneField( - Counter, verbose_name=_("counter"), related_name="launderette" + Counter, + verbose_name=_("counter"), + related_name="launderette", + on_delete=models.CASCADE, ) class Meta: diff --git a/stock/models.py b/stock/models.py index 39c2f499..f23ba277 100644 --- a/stock/models.py +++ b/stock/models.py @@ -39,7 +39,10 @@ class Stock(models.Model): name = models.CharField(_("name"), max_length=64) counter = models.OneToOneField( - Counter, verbose_name=_("counter"), related_name="stock" + Counter, + verbose_name=_("counter"), + related_name="stock", + on_delete=models.CASCADE, ) def __str__(self): diff --git a/trombi/models.py b/trombi/models.py index f0b32828..5b0b0e2b 100644 --- a/trombi/models.py +++ b/trombi/models.py @@ -80,7 +80,7 @@ class Trombi(models.Model): show_profiles = models.BooleanField( _("show users profiles to each other"), default=True ) - club = models.OneToOneField(Club, related_name="trombi") + club = models.OneToOneField(Club, related_name="trombi", on_delete=models.CASCADE) objects = TrombiManager() availables = AvailableTrombiManager() @@ -117,7 +117,10 @@ class TrombiUser(models.Model): """ user = models.OneToOneField( - User, verbose_name=_("trombi user"), related_name="trombi_user" + User, + verbose_name=_("trombi user"), + related_name="trombi_user", + on_delete=models.CASCADE, ) trombi = models.ForeignKey( Trombi,